From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: =?UTF-8?B?0JDQvdC00YDQtdC5INCg0LDRh9C40YbQutC40Lk=?=
 <therealgofman@mail.ru>,
        pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18545: \dt breaks transaction,
 calling error when executed in SET SESSION AUTHORIZATION
In-reply-to: 
 <CA+TgmoZ8owNGNkHUsoSL3cEd8C+zbb8w7-Oje0HYvfBp+btDBA@mail.gmail.com>
References: <18545-feba138862f19aaa@postgresql.org>
 <72802.1721415837@sss.pgh.pa.us> <1722241488.182053205@f169.i.mail.ru>
 <3593204.1722466756@sss.pgh.pa.us> <3618203.1722473994@sss.pgh.pa.us>
 <916377.1722809337@sss.pgh.pa.us>
 <CA+TgmoZ8owNGNkHUsoSL3cEd8C+zbb8w7-Oje0HYvfBp+btDBA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Tue, 06 Aug 2024 14:48:06 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <1807626.1722970465.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Tue, 06 Aug 2024 14:54:25 -0400
Message-ID: <1807627.1722970465@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1807627.1722970465%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Sun, Aug 4, 2024 at 6:08 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> However, what the farm found is that assign_client_encoding
>> is flat-out broken.  It's ignoring the first commandment
>> for GUC hooks, which is "Thy assign hooks shalt not fail".

> Interesting. Looks like my mistake, dating to
> 10c0558ffefcd12bf1d3dc35587eba41d1ce4571. I'm honestly kind of
> surprised that nobody discovered this problem for 8 years. I would
> have expected it to cause more problems.

Yeah, it's a bit accidental that that's not reachable up to now.
Or I think it's not reachable, anyway.  If we find out differently
we can back-patch 0ae5b763e, but for now I refrained.

			regards, tom lane