From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: balazs@obiserver.hu, pgsql-bugs@postgresql.org,
        pgsql-hackers@postgresql.org
Subject: Re: BUG #14825: enum type: unsafe use?
In-reply-to: <9479302a-09b8-4264-f9c4-514b65f18547@2ndQuadrant.com>
References: <20170922185904.1448.16585@wrigleys.postgresql.org>
 <15165.1506116768@sss.pgh.pa.us>
 <3cece400-af56-7145-2e65-f044de1b0b68@2ndQuadrant.com>
 <28968.1506136792@sss.pgh.pa.us>
 <f29e2d7e-7d71-b3b7-2fed-d52bddd8ca61@2ndQuadrant.com>
 <24380.1506179805@sss.pgh.pa.us> <16272.1506189656@sss.pgh.pa.us>
 <928f5974-151f-0273-0221-fac213e7624f@2ndQuadrant.com>
 <19137.1506196325@sss.pgh.pa.us>
 <4942e2c0-3302-f496-d4c1-a967f77d0143@2ndQuadrant.com>
 <25662.1506204381@sss.pgh.pa.us>
 <9479302a-09b8-4264-f9c4-514b65f18547@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Sun, 24 Sep 2017 16:19:37 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <18126.1506285450.1@sss.pgh.pa.us>
Date: Sun, 24 Sep 2017 16:37:30 -0400
Message-ID: <18127.1506285450@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> OK, here's the finished patch. It has a pretty small footprint all
> things considered, and I think it guarantees that nothing that could be
> done in this area in 9.6 will be forbidden. That's probably enough to
> get us to 10 without having to revert the whole thing, ISTM, and we can
> leave any further refinement to the next release.

I think this could do with some more work on the comments and test cases,
but it's basically sound.

What we still need to debate is whether to remove the heuristic
type-is-from-same-transaction test, making the user-visible behavior
simply "you must commit an ALTER TYPE ADD VALUE before you can use the
new value".  I'm kind of inclined to do so; the fuzzy (and inadequately
documented) behavior we'll have if we keep it doesn't seem very nice to
me.

			regards, tom lane


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs