From: Tom Lane <tgl@sss.pgh.pa.us>
To: Euler Taveira <euler.taveira@2ndquadrant.com>
cc: pgsql-bugs@lists.postgresql.org, m.sakrejda@gmail.com
Subject: Re: BUG #16502: EXPLAIN JSON format adds extra quotes around index
 names
In-reply-to: 
 <CAH503wCS_XAQkFtH5xFeiL52tQpYc_qRbdFt3X-e8vfUP9pMdA@mail.gmail.com>
References: <16502-57bd1c9f913ed1d1@postgresql.org>
 <CAH503wCS_XAQkFtH5xFeiL52tQpYc_qRbdFt3X-e8vfUP9pMdA@mail.gmail.com>
Comments: In-reply-to Euler Taveira <euler.taveira@2ndquadrant.com>
	message dated "Sat, 20 Jun 2020 15:22:17 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1816978.1592680000.1@sss.pgh.pa.us>
Date: Sat, 20 Jun 2020 15:06:40 -0400
Message-ID: <1816979.1592680000@sss.pgh.pa.us>
Precedence: bulk

Euler Taveira <euler.taveira@2ndquadrant.com> writes:
> Indeed, relation names should return the same. The fact that
> explain_get_index_name always calls quote_identifier is the culprit; it
> should call quote_identifier only when the format is TEXT. Patch is
> attached.

Agreed as to the bug, but I think we ought to fix it by redefining
explain_get_index_name's API as "return the bare index name always",
and let the callers apply quoting.  The callers seem to all have
separate code paths for text format already.  Furthermore, if
explain_get_index_name needs to have different behavior for text
format, that requirement propagates to explain_get_index_name_hook
functions --- and I don't think we want to change the signature
for that hook.

			regards, tom lane