pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #18173: ERROR: could not identify a comparison function for type unknown
4+ messages / 4 participants
[nested] [flat]
* BUG #18173: ERROR: could not identify a comparison function for type unknown
@ 2023-10-30 13:24 PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: PG Bug reporting form @ 2023-10-30 13:24 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: 409800246@qq.com
The following bug has been logged on the website:
Bug reference: 18173
Logged by: JennyJennyChen
Email address: 409800246@qq.com
PostgreSQL version: 16.0
Operating system: CentOS Linux release 7.9 (Final)
Description:
postgres=# CREATE TABLE test_v(id int,name varchar(30));
CREATE TABLE
postgres=# insert into test_v values(9,'abc'),(9,'def'),(9,'gh'),
(9,'gh');
INSERT 0 4
postgres=# explain (costs off) select distinct
(id,name,'D3Q84xpymM',123,'123') from test_v;
QUERY PLAN
-------------------------------------------------------------
Unique
-> Sort
Sort Key: (ROW(id, name, 'D3Q84xpymM', 123, '123'))
-> Seq Scan on test_v
(4 rows)
postgres=# select distinct (id,name,'D3Q84xpymM',123,'123') from test_v;
ERROR: could not identify a comparison function for type unknown
postgres=#
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #18173: ERROR: could not identify a comparison function for type unknown
@ 2023-10-31 11:10 Laurenz Albe <laurenz.albe@cybertec.at>
parent: PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 4+ messages in thread
From: Laurenz Albe @ 2023-10-31 11:10 UTC (permalink / raw)
To: 409800246@qq.com; pgsql-bugs@lists.postgresql.org
On Mon, 2023-10-30 at 13:24 +0000, PG Bug reporting form wrote:
> PostgreSQL version: 16.0
>
> postgres=# CREATE TABLE test_v(id int,name varchar(30));
> CREATE TABLE
> postgres=# insert into test_v values(9,'abc'),(9,'def'),(9,'gh'),
> (9,'gh');
> INSERT 0 4
> postgres=# explain (costs off) select distinct
> (id,name,'D3Q84xpymM',123,'123') from test_v;
> QUERY PLAN
> -------------------------------------------------------------
> Unique
> -> Sort
> Sort Key: (ROW(id, name, 'D3Q84xpymM', 123, '123'))
> -> Seq Scan on test_v
> (4 rows)
>
> postgres=# select distinct (id,name,'D3Q84xpymM',123,'123') from test_v;
> ERROR: could not identify a comparison function for type unknown
This is not a bug. You probably want to remove the parentheses.
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #18173: ERROR: could not identify a comparison function for type unknown
@ 2023-10-31 14:51 Tom Lane <tgl@sss.pgh.pa.us>
parent: Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2023-10-31 14:51 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: 409800246@qq.com; pgsql-bugs@lists.postgresql.org
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Mon, 2023-10-30 at 13:24 +0000, PG Bug reporting form wrote:
>> postgres=# select distinct (id,name,'D3Q84xpymM',123,'123') from test_v;
>> ERROR: could not identify a comparison function for type unknown
> This is not a bug. You probably want to remove the parentheses.
It is a bit inconsistent that we allow
select distinct id,name,'D3Q84xpymM',123,'123' from test_v;
and
select (id,name,'D3Q84xpymM',123,'123') from test_v;
but not the above. Poking around, I discovered a related failure:
select ((id,name,'D3Q84xpymM',123,'123')).f3 from test_v;
ERROR: failed to find conversion function from unknown to text
That happens because at the end of parsing we apply
resolveTargetListUnknowns, which sees that there's an UNKNOWN
output column and tries to coerce it to text, but can't since
it's not a plain literal.
So maybe there is a case for forcing unknowns to text in the
input list of a RowExpr. You could argue that a RowExpr is
morally the same thing as a SELECT list, so this would have
some consistency to it. Nonetheless, it's a rather big
semantics change and I wonder what it might break. Notably,
in the context
row(...,'foo',...)::somerowtype
currently the cast to somerowtype will see an unknown literal
and do the right thing, whereas maybe with text input it might
do something surprising (and in any case we'd lose some
efficiency from the extra type coercion).
On the whole, given the lack of complaints for the last couple
of decades, I'm content to say that it's operating as intended.
At best we'd be switching from one nonstandard behavior to
another. ("Oracle does it" doesn't make it standard.)
In any case, I don't like the proposed patch one bit.
Kluging this up in the specific case of DISTINCT is just
adding a wart.
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #18173: ERROR: could not identify a comparison function for type unknown
@ 2023-11-01 07:44 下雨天 <409800246@qq.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: 下雨天 @ 2023-11-01 07:44 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: pgsql-bugs <pgsql-bugs@lists.postgresql.org>
Perhaps you're right.
Different databases have their unique characteristics, and there is indeed no need to be compatible with Oracle.
At least in the specific case of DISTINCT, it indeed increases the workload for users migrating from Oracle to PostgreSQL, which seems inevitable at present.
Thanks!
------------------ Original ------------------
From: "Tom Lane" <tgl@sss.pgh.pa.us>;
Date: Tue, Oct 31, 2023 10:51 PM
To: "Laurenz Albe"<laurenz.albe@cybertec.at>;
Cc: "下雨天"<409800246@qq.com>;"pgsql-bugs"<pgsql-bugs@lists.postgresql.org>;
Subject: Re: BUG #18173: ERROR: could not identify a comparison function for type unknown
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Mon, 2023-10-30 at 13:24 +0000, PG Bug reporting form wrote:
>> postgres=# select distinct (id,name,'D3Q84xpymM',123,'123') from test_v;
>> ERROR: could not identify a comparison function for type unknown
> This is not a bug. You probably want to remove the parentheses.
It is a bit inconsistent that we allow
select distinct id,name,'D3Q84xpymM',123,'123' from test_v;
and
select (id,name,'D3Q84xpymM',123,'123') from test_v;
but not the above. Poking around, I discovered a related failure:
select ((id,name,'D3Q84xpymM',123,'123')).f3 from test_v;
ERROR: failed to find conversion function from unknown to text
That happens because at the end of parsing we apply
resolveTargetListUnknowns, which sees that there's an UNKNOWN
output column and tries to coerce it to text, but can't since
it's not a plain literal.
So maybe there is a case for forcing unknowns to text in the
input list of a RowExpr. You could argue that a RowExpr is
morally the same thing as a SELECT list, so this would have
some consistency to it. Nonetheless, it's a rather big
semantics change and I wonder what it might break. Notably,
in the context
row(...,'foo',...)::somerowtype
currently the cast to somerowtype will see an unknown literal
and do the right thing, whereas maybe with text input it might
do something surprising (and in any case we'd lose some
efficiency from the extra type coercion).
On the whole, given the lack of complaints for the last couple
of decades, I'm content to say that it's operating as intended.
At best we'd be switching from one nonstandard behavior to
another. ("Oracle does it" doesn't make it standard.)
In any case, I don't like the proposed patch one bit.
Kluging this up in the specific case of DISTINCT is just
adding a wart.
regards, tom lane
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-11-01 07:44 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-10-30 13:24 BUG #18173: ERROR: could not identify a comparison function for type unknown PG Bug reporting form <noreply@postgresql.org>
2023-10-31 11:10 ` Laurenz Albe <laurenz.albe@cybertec.at>
2023-10-31 14:51 ` Re: BUG #18173: ERROR: could not identify a comparison function for type unknown Tom Lane <tgl@sss.pgh.pa.us>
2023-11-01 07:44 ` Re: BUG #18173: ERROR: could not identify a comparison function for type unknown 下雨天 <409800246@qq.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox