Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPnRB-0004ks-3H for pgsql-bugs@arkaria.postgresql.org; Tue, 06 Oct 2020 13:55:29 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kPnR9-0007jb-Q8 for pgsql-bugs@arkaria.postgresql.org; Tue, 06 Oct 2020 13:55:27 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPnR9-0007jI-Jg for pgsql-bugs@lists.postgresql.org; Tue, 06 Oct 2020 13:55:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kPnR6-0007Tt-Np for pgsql-bugs@lists.postgresql.org; Tue, 06 Oct 2020 13:55:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 096DtLXN1867089; Tue, 6 Oct 2020 09:55:22 -0400 From: Tom Lane To: "Y. NAKAGAWA" cc: pgsql-bugs@lists.postgresql.org Subject: Re: BUG #16645: pg_upgrade does not mark template1 as a system database In-reply-to: <03c101d69bc5$53380090$f9a801b0$@goodf.co.jp> References: <16645-54478f8719888f75@postgresql.org> <805341.1601433939@sss.pgh.pa.us> <029201d696df$c1542940$43fc7bc0$@goodf.co.jp> <03c101d69bc5$53380090$f9a801b0$@goodf.co.jp> Comments: In-reply-to "Y. NAKAGAWA" message dated "Tue, 06 Oct 2020 18:44:43 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1867087.1601992521.1@sss.pgh.pa.us> Date: Tue, 06 Oct 2020 09:55:21 -0400 Message-ID: <1867088.1601992521@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk "Y. NAKAGAWA" writes: > However, after some grep-ing on pgAdmin4 source tree, I found that [System > Database?] shows pg_database.oid <= pg_database.datlastsysoid. That is a very meaningless condition, they shouldn't do that. regards, tom lane