Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kG0J5-0007Pv-6y
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 13:38:39 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1kG0J4-0004j2-5n
	for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 13:38:38 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kG0J3-0004iu-VU
	for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2020 13:38:37 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1kG0J1-0003Qe-P0
	for pgsql-hackers@postgresql.org; Wed, 09 Sep 2020 13:38:36 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 089DcVnX1893469;
	Wed, 9 Sep 2020 09:38:31 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Pavel Stehule <pavel.stehule@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>,
        Thomas Munro <thomas.munro@gmail.com>,
        Petr Fedorov <petr.fedorov@phystech.edu>
Subject: Re: Since '2001-09-09 01:46:40'::timestamp microseconds are lost when
 extracting epoch
In-reply-to: <097a4242-0748-98e3-06ab-ded1d366cd76@2ndquadrant.com>
References: <42b73d2d-da12-ba9f-570a-420e0cce19d9@phystech.edu>
 <CA+hUKGKgHUbFNKRhvodn4mVU-oqje+HA7jTg_XrWRo4UGhFoqg@mail.gmail.com>
 <18389.1575241151@sss.pgh.pa.us>
 <1c2262e2-6812-7baa-cbdd-63039db12952@phystech.edu>
 <CA+hUKGK+K8NyS57tU841m1tSF6ha3W0udN2dw_Hbc=D_0OPbmA@mail.gmail.com>
 <ee683994-8f7c-aded-be43-543e66e68b94@2ndquadrant.com>
 <a3be61d9-f44b-7fce-3dc8-d700fdfb6f48@2ndquadrant.com>
 <CAFj8pRC8cgoiQMT235cky4Pa40gj=s0m3PftmaJLSt9MAiwj_Q@mail.gmail.com>
 <be30c07c-3f7b-7c86-f1c5-d0858046b26f@2ndquadrant.com>
 <1551357.1599435992@sss.pgh.pa.us>
 <097a4242-0748-98e3-06ab-ded1d366cd76@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 09 Sep 2020 10:08:06 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1893467.1599658711.1@sss.pgh.pa.us>
Date: Wed, 09 Sep 2020 09:38:31 -0400
Message-ID: <1893468.1599658711@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 2020-09-07 01:46, Tom Lane wrote:
>> I reviewed the 0002 patch, finding one bug (in int8_sum)

> Ouch, no test coverage.  Should we perhaps remove this function, since 
> it's obsolete and unused?

I don't feel a need to.

>> and a few
>> more calls of int8_numeric that could be converted.  I think the
>> attached updated version is committable, and I'd recommend going
>> ahead with that regardless of the rest of this.  I hadn't realized
>> how many random calls of int8_numeric and int4_numeric we'd grown,
>> but there are a lot, so this is nice cleanup.

> Yes, please go ahead with it.

It's your patch, I figured you'd want to commit it.

			regards, tom lane