From: Tom Lane <tgl@sss.pgh.pa.us>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
cc: buschmann@nidsa.net, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16045: vacuum_db crash and illegal memory alloc after
 pg_upgrade from PG11 to PG12
In-reply-to: <20191009230759.ge66neof5qj627a2@development>
References: <16045-673e8fa6b5ace196@postgresql.org>
 <20191009132436.uugh4r3be6vw6ex4@development>
 <20191009135907.km2b5nrzflcz6xey@development>
 <20191009141841.my6k44wfiaquj3ks@development>
 <20191009230759.ge66neof5qj627a2@development>
Comments: In-reply-to Tomas Vondra <tomas.vondra@2ndquadrant.com>
	message dated "Thu, 10 Oct 2019 01:07:59 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19313.1570663125.1@sss.pgh.pa.us>
Date: Wed, 09 Oct 2019 19:18:45 -0400
Message-ID: <19314.1570663125@sss.pgh.pa.us>
Precedence: bulk

Tomas Vondra <tomas.vondra@2ndquadrant.com> writes:
> Well, I think I found the root cause. It's because of 7c15cef86d, which
> changed the definition of sql_identifier so that it's a domain over name
> instead of varchar.

Ah...

> Not sure what to do about this :-(

Fortunately, there should be close to zero people with user tables
depending on sql_identifier.  I think we should just add a test in
pg_upgrade that refuses to upgrade if there are any such columns.
It won't be the first such restriction.

			regards, tom lane