From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Daniel Gustafsson <daniel@yesql.se>,
 Thomas Munro <thomas.munro@gmail.com>,
        byavuz81@gmail.com,
        PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
        Heikki Linnakangas <heikki.linnakangas@iki.fi>,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: BUG #17391: While using --with-ssl=openssl and
 PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0
In-reply-to: <20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de>
References: <131329.1643851912@sss.pgh.pa.us>
 <203742.1643866877@sss.pgh.pa.us>
 <C44CE9FB-B37E-47D3-924B-4AF808AE98B1@yesql.se>
 <887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se>
 <621771.1644098845@sss.pgh.pa.us> <635760.1644108785@sss.pgh.pa.us>
 <1113966.1644280235@sss.pgh.pa.us>
 <C112C400-2CB5-4DCA-A699-00DC0333B665@yesql.se>
 <1537890.1644462214@sss.pgh.pa.us> <1952254.1644540297@sss.pgh.pa.us>
 <20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 10 Feb 2022 17:10:25 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1955928.1644542728.1@sss.pgh.pa.us>
Date: Thu, 10 Feb 2022 20:25:28 -0500
Message-ID: <1955929.1644542728@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1955929.1644542728%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> It's not in this change, but related. I don't really understand the

> 	/*
> 	 * PQgetResult will return immediately in all states except BUSY, or if we
> 	 * had a write failure.
> 	 */
> 	return conn->asyncStatus == PGASYNC_BUSY || conn->write_failed;

> business in PQisBusy(). Won't that potentially lead to clients waiting for
> more network IO indefinitely, never getting around to calling PQgetResult()?

I was staring at that for awhile too.  It's my own code (from 1f39a1c0641)
but it sure confuses me now; at the very least the code is not in sync
with the comment.  However, it's been that way for a couple years now and
we've not had complaints suggesting it's broken, so maybe it's the comment
that's wrong.

			regards, tom lane