From: Tom Lane <tgl@sss.pgh.pa.us>
To: exclusion@gmail.com
cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #16266: Server crash on SELECT event_trigger-returning
 function
In-reply-to: <16266-fcd7f838e97ba5d4@postgresql.org>
References: <16266-fcd7f838e97ba5d4@postgresql.org>
Comments: In-reply-to PG Bug reporting form <noreply@postgresql.org>
	message dated "Wed, 19 Feb 2020 08:00:01 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19564.1582128305.1@sss.pgh.pa.us>
Date: Wed, 19 Feb 2020 11:05:05 -0500
Message-ID: <19565.1582128305@sss.pgh.pa.us>
Precedence: bulk

PG Bug reporting form <noreply@postgresql.org> writes:
> The following query:
> CREATE OR REPLACE FUNCTION et() RETURNS event_trigger
> LANGUAGE plpgsql AS $$
> BEGIN
> END;
> $$;
> SELECT et();

> leads to a server crash with the following stack trace:

Yeah.  If you didn't just validate the function, it does the expected
thing:

regression=# SELECT et();
ERROR:  trigger functions can only be called as triggers
CONTEXT:  compilation of PL/pgSQL function "et" near line 1

I think perhaps the problem is that compute_function_hashkey hasn't
been fixed to deal with event triggers sanely.  They need to not
have the same hash keys as ordinary function calls.

			regards, tom lane