Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nILH5-0000AJ-5M for pgsql-bugs@arkaria.postgresql.org; Fri, 11 Feb 2022 02:03:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nILH3-0005WG-QX for pgsql-bugs@arkaria.postgresql.org; Fri, 11 Feb 2022 02:03:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nILH3-0005W7-IK for pgsql-bugs@lists.postgresql.org; Fri, 11 Feb 2022 02:03:01 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nILH1-0000KF-0H for pgsql-bugs@lists.postgresql.org; Fri, 11 Feb 2022 02:03:00 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21B22po61959197; Thu, 10 Feb 2022 21:02:51 -0500 From: Tom Lane To: Andres Freund cc: Daniel Gustafsson , Thomas Munro , byavuz81@gmail.com, PostgreSQL mailing lists , Heikki Linnakangas , Michael Paquier Subject: Re: BUG #17391: While using --with-ssl=openssl and PG_TEST_EXTRA='ssl' options, SSL tests fail on OpenBSD 7.0 In-reply-to: <20220211015455.mkl6cvstttp5zfco@alap3.anarazel.de> References: <887CBA28-0942-4084-BE09-FBE0D6A1DB53@yesql.se> <621771.1644098845@sss.pgh.pa.us> <635760.1644108785@sss.pgh.pa.us> <1113966.1644280235@sss.pgh.pa.us> <1537890.1644462214@sss.pgh.pa.us> <1952254.1644540297@sss.pgh.pa.us> <20220211011025.ek7exh6owpzjyudn@alap3.anarazel.de> <1955929.1644542728@sss.pgh.pa.us> <20220211015455.mkl6cvstttp5zfco@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 10 Feb 2022 17:54:55 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1959195.1644544971.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 10 Feb 2022 21:02:51 -0500 Message-ID: <1959196.1644544971@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-02-10 20:25:28 -0500, Tom Lane wrote: >> I was staring at that for awhile too. It's my own code (from 1f39a1c06= 41) >> but it sure confuses me now; at the very least the code is not in sync >> with the comment. However, it's been that way for a couple years now a= nd >> we've not had complaints suggesting it's broken, so maybe it's the comm= ent >> that's wrong. > I wonder if it could be part of the whole "walreceiver on windows not no= ticing > connection death" business. Hmm, maybe. It sure *looks* like we need to do - return conn->asyncStatus =3D=3D PGASYNC_BUSY || conn->write_failed; + return conn->asyncStatus =3D=3D PGASYNC_BUSY && !conn->write_failed; If anyone who can reproduce that Windows problem wants to try that ... regards, tom lane