From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: bianpan2016@163.com, pgsql-bugs@lists.postgresql.org,
        Robert Haas <robertmhaas@gmail.com>
Subject: Re: BUG #15105: OpenTransientFile() should be paired with
 CloseTransientFile() rather than close()
In-reply-to: <20180309044052.GC1416@paquier.xyz>
References: <152056616579.4966.583293218357089052@wrigleys.postgresql.org>
 <20180309044052.GC1416@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Fri, 09 Mar 2018 13:40:52 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <19685.1520607468.1@sss.pgh.pa.us>
Date: Fri, 09 Mar 2018 09:57:48 -0500
Message-ID: <19686.1520607468@sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> On Fri, Mar 09, 2018 at 03:29:25AM +0000, PG Bug reporting form wrote:
>> Details: The handler opened with OpenTransientFile() should be closed with
>> CloseTransientFile(). However, in function dsm_impl_mmap(), on a certain
>> path, the return value of OpenTransientFile() (at line 885) is passed to
>> close() (at line 926). It is better to use CloseTransientFile() here, as
>> done at line 909.

> Good catch!  This is visibly a copy-paste error coming from
> dsm_impl_posix().  As a patch it gives the attached.  I am adding also
> Robert in CC for awareness.

Presumably, this would have been found sooner if AtEOXact_Files acted
like most other end-of-xact cleanup functions and whined about leaked
resources (in the commit case).  I wonder why it doesn't.

			regards, tom lane