From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: Alex Malek <magicagent@gmail.com>, pgsql-bugs@lists.postgresql.org,
        ngigi@at.co.ke
Subject: Re: BUG #15172: Postgresql ts_headline with <-> operator does not
 highlight text properly
In-reply-to: <ZT1kGIbiALGclTUA@momjian.us>
References: <152461454026.19805.6310947081647212894@wrigleys.postgresql.org>
 <CAGH8cccS-9yb1VkgUTAaghz4P3aL8DneH_24bN7Y0LCLO8by1Q@mail.gmail.com>
 <ZT1kGIbiALGclTUA@momjian.us>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Sat, 28 Oct 2023 15:42:16 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1995600.1698526000.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Sat, 28 Oct 2023 16:46:40 -0400
Message-ID: <1995601.1698526000@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/1995601.1698526000%40sss.pgh.pa.us>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> Is this documented somewhere?

The docs [1] only say that ts_headline "returns an excerpt from the
document in which terms from the query are highlighted".  This
behavior does not violate that admittedly-weak contract.

IIRC, ts_headline does attempt to find a text fragment or fragments
that fully satisfy the query (e.g., include an exact phrase match)
but it will then highlight all the matching words in the fragment,
not only the location of the phrase match.  I do not agree with the
OP's opinion that that's wrong.  The highlight-em-all approach has its
own value, and in any case it may not be possible to find a full match
that satisfies the function's other constraints such as MaxWords.
Refusing to highlight anything in that event would be unhelpful.

			regards, tom lane

[1] https://www.postgresql.org/docs/current/textsearch-controls.html#TEXTS=
EARCH-HEADLINE