Date: Thu, 26 Feb 2026 11:34:02 +0530
From: Vishal Prasanna <vishal.g@zohocorp.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: =?UTF-8?Q?=22=27=C3=81lvaro_Herrera=27=22?= <alvherre@kurilemu.de>,
	"pgsql-bugs" <pgsql-bugs@lists.postgresql.org>
Message-ID: <19c988c1266.2196acf489066.5725883611676009019@zohocorp.com>
In-Reply-To: <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: <19c95a57600.599bb79483132.9142801067257165882@zohocorp.com>
 <202602251653.e66kyhiyntlm@alvherre.pgsql> <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical
 decoding due to leaked specinsert change
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Importance: Medium
User-Agent: Zoho Mail
Archived-At: <https://www.postgresql.org/message-id/19c988c1266.2196acf489066.5725883611676009019%40zohocorp.com>
Precedence: bulk


Dear Hayato, =C3=81lvaro,

>> Please don't do this. Changing the argument list of an exported
>> function is an ABI break. That's an OK change to do in branch master
>> (to keep the interface clean), but for released branches it is not
>> welcome, because it causes problems for users that have extensions that
>> call the function and were compiled with its older definition.
>
> To confirm, ReorderBufferResetTXN() seems a static function and proposed =
patch
> does not modify *.h files. So they do not break the ABI and OK to remove,=
 right?

```
File: reorderbuffer.c
2156: /*
2157:  * Helper function for ReorderBufferProcessTXN to handle the concurre=
nt
2158:  * abort of the streaming transaction.  This resets the TXN such that=
 it
2159:  * can be used to stream the remaining data of transaction being proc=
essed.
2160:  * This can happen when the subtransaction is aborted and we still wa=
nt to
2161:  * continue processing the main or other subtransactions data.
2162:  */
2163: static void
2164: ReorderBufferResetTXN(ReorderBuffer *rb, ReorderBufferTXN *txn,
```

Confirmed, `ReorderBufferResetTXN()` is a static function used only by Reor=
derBufferProcessTXN().
It is not exposed outside reorderbuffer.c, and the patch does not affect an=
y public exported function.


Regards,
Vishal Prasanna
Zoho Corporation