Date: Mon, 09 Mar 2026 15:09:51 +0530
From: Vishal Prasanna <vishal.g@zohocorp.com>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>
Cc: =?UTF-8?Q?=22=27=C3=81lvaro_Herrera=27=22?= <alvherre@kurilemu.de>,
	"pgsql-bugs" <pgsql-bugs@lists.postgresql.org>
Message-ID: <19cd1f79e36.6f207bc310439.5806765603673787544@zohocorp.com>
In-Reply-To: <OS9PR01MB1214923A50CA2640D572FEBE1F579A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
References: <19c95a57600.599bb79483132.9142801067257165882@zohocorp.com>
 <202602251653.e66kyhiyntlm@alvherre.pgsql>
 <OS9PR01MB12149FD6C66A344831EBD836EF572A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <19c988c1266.2196acf489066.5725883611676009019@zohocorp.com>
 <OS9PR01MB1214961799DAE95F5CB32EC75F57FA@OS9PR01MB12149.jpnprd01.prod.outlook.com>
 <19ccf4ccdb3.2e31ab735232.2694179375476897261@zohocorp.com> <OS9PR01MB1214923A50CA2640D572FEBE1F579A@OS9PR01MB12149.jpnprd01.prod.outlook.com>
Subject: RE: [BUG] Assert failure in ReorderBufferReturnTXN during logical
 decoding due to leaked specinsert change
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Importance: Medium
User-Agent: Zoho Mail
Archived-At: <https://www.postgresql.org/message-id/19cd1f79e36.6f207bc310439.5806765603673787544%40zohocorp.com>
Precedence: bulk

Hi Hayato,

 > ``` 
 > @@ -2663,6 +2655,13 @@ ReorderBufferProcessTXN(ReorderBuffer *rb, ReorderBufferTXN *txn, 
 >          if (using_subtxn) 
 >              RollbackAndReleaseCurrentSubTransaction(); 
 >  
 > +        /* Free the specinsert change before freeing the ReorderBufferTXN */ 
 > +        if (specinsert != NULL) 
 > +        { 
 > +            ReorderBufferReturnChange(rb, specinsert, true); 
 > +            specinsert = NULL; 
 > +        } 
 > ``` 
 >  
 > In PG17-, we seem to use the term "return" to deallocate the change. Should we follow that? 
 > I have no strong opinion for it. 

Internally, `ReorderBufferReturnChange()` frees the change, which is why comment uses "Free".
Either term is fine for me.


Thanks for the review and for registering the patch.

Regards,
Vishal Prasanna
Zoho Corporation