Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xQ4ZQ-000000018tt-3i9I for pgsql-bugs@arkaria.postgresql.org; Sun, 08 Nov 2026 15:12:38 +0000 Received: from localhost ([127.0.0.1]:39534 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xQ4ZR-00000006GPH-0qlx for pgsql-bugs@arkaria.postgresql.org; Sun, 08 Nov 2026 15:12:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:49638) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xQ4Y9-00000006E7v-3PLB for pgsql-bugs@lists.postgresql.org; Sun, 08 Nov 2026 15:11:17 +0000 Received: from mail-wm2-x09.google.com ([2a00:1450:4864:31::9]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1xQ4Y7-000000013pQ-1Ldf for pgsql-bugs@lists.postgresql.org; Sun, 08 Nov 2026 15:11:17 +0000 Received: by mail-wm2-x09.google.com with SMTP id 5b1f17b1804b1-4b76ade741cso503715e9.0 for ; Sun, 08 Nov 2026 07:11:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794150674; x=1794755474; darn=lists.postgresql.org; h=in-reply-to:from:references:to:subject:user-agent:mime-version:date :message-id:content-type:from:to:cc:subject:date:message-id:reply-to :content-type; bh=4YDDJzOFwX6L/dVzMO21gAELz87lg7Fs3in1qcs8aAs=; b=vMZgBwahpH/TMtgtzeipEC6r995XZ80wH3Ccyt3Pe6nvK9Q5rT4d7injgmD3Qgl8zp wwtTwJFizh7v5p6shq8j4BS7FhSM5EANSN3ZZLm4WsuOd9gAi0AEoTUcAjLM25/9xHcV zuM8znmsWq+F66bhLnAgFvAJTlLpwDfQny8cVZVIlYV8xNLTQ6M5a3f+Ex/rmt414jSZ iXqKKE6aaJXPXZJIQd6rKnNcld1zeC4VQcyESuwPN4By3LCVsdam0yf590jUvG/F91Ic Ptc+IqRSuIlMxgZmf0MHTvsE3PKiWDmePreluoJcH+hm7l1YQ2KMRxZGT3+3AwXc8Bg0 XXEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794150674; x=1794755474; h=in-reply-to:from:references:to:subject:user-agent:mime-version:date :message-id:content-type:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=4YDDJzOFwX6L/dVzMO21gAELz87lg7Fs3in1qcs8aAs=; b=RnblKanL33hjb9wC+hgqjHmGPq8H7QDvBPYw5PhyQwNBpGonjpEfaI+F7zVUkQP868 kYNDqCB+cs2120NYJtTmc2hgl7RJt3nTpyfhJrh8QqwHlqnElKgogrGV6FymHldtdHcP cXS9pjPZAwleaM6RJabwMgrVcgNirJFlpENzJo/a4NiWg1+HSaTK07d+19mH93sTTSWW lNbsXBWsx2wV/nizyKZGuYz8XeH8Y3mB4WUtFZ6ZSBiflYuPjZ080D0FfNdx3MIhZ0QG DzGL82fjmECpniFJuTzFtXqxtW5jXeVG5Iy2GdawNRfAHOR9+zZeJhMb7l42kAuismY/ JDgg== X-Forwarded-Encrypted: i=1; AL+hErEUqLYBknI6sWs+tKltHIvghRoWCwRg8095yKpqBhZopwQgazb2hxrHeuw1Ko5x5MR+WpjFfgIs1r86@lists.postgresql.org X-Gm-Message-State: APuU4Z+98X4YyFpfkMnoff8N5DR4En1hjIKbadHpSHYZrfLz2Mkk/AdW vtnZNJq9kCCUnUPaNk6fBi2cFGmOrZQZ+3RZr1rtYhce4OGWd0vy6zy4 X-Gm-Gg: AYBFou1N1TeU+H0Zdf/On/F/KbNlJoxAKolp2eihniS/aPVbBvEIYB/HnlAEOo7Mu22 qKfMAVoVHuvt0Y1+0EXKgaf8UniOARO2XusIhckq4sR/sOUgd2w+wLS5nsQAjVjb4IsJsUZPYAM hRMaEY/7Fecmp086zFWBtRIoxTDlAtwxaVNOJQP+1wIhLqGPutGNsUUacIo2VtdbG66Wb1LXE0j qbXqJeRehWlUaxrcafcQQP+cIJQNScB8gDnrqzji36W+oMD7RGlr4E0FDs329FvLOwdSGBlSudM RJLI4n73ByiOD2MnLbc6M/2JbBnIiubfQ/iMs72D3RHs5+8UZajq8vmg0LOwefTdAVuCK3KcMMl Pvl0GB2xb36mXqVZX+HHJMB9LWvAKcKeMR+/+JtMdleSNbS3MbFsglVHAHJ89IaZOoXkabi75rZ 7j7ngk7FQWJTMRokkXm3JSkrd+JWaolgULOwsPoTH0kBnrBxNUQjy0A/LWsw/5HxuGCqA+PuMvJ Y7rXm7qX6EjJdM3hJdGMtMyaEJ1bFT4sI2G0Ab5DQypDfv9YgHS/ym5/+97EUQCR7jAbVfESRt9 Hz1v0LhrGeKMB6eLRGI65ZiX5nWDwMauA+mtPG2cf6RWNszXYteobD8hwjwOHM4+K5tVJUhCMuF It8qXbbON8eAm7JdvF2wFlGN/BomvcOmYPJMWVeVZB+lJpj/q3Ytyj6kSHS+/ X-Received: by 2002:a05:600c:4e87:b0:4a3:12fb:1ef1 with SMTP id 5b1f17b1804b1-4b963c8c87cmr33659865e9.29.1794150673907; Sun, 08 Nov 2026 07:11:13 -0800 (PST) Received: from [17.235.205.38] ([17.235.205.38]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4b7efb0b0c2sm140318905e9.8.2026.11.08.07.11.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 08 Nov 2026 07:11:13 -0800 (PST) Content-Type: multipart/mixed; boundary="------------kC07iR0F9VoMzarBg04gCi98" Message-ID: <1da45744-968f-4f40-addf-dc085e928ec5@gmail.com> Date: Sun, 8 Nov 2026 23:11:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: BUG #19839: Assert in ReorderBufferRestoreCleanup for aborted, spilled transaction To: Atisss hh <125atishprak@gmail.com>, pgsql-bugs@lists.postgresql.org References: <19839-ead02c2208a3f8bd@postgresql.org> From: Zhijie Hou In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------kC07iR0F9VoMzarBg04gCi98 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, On Sat, Nov 7, 2026 at 09:26 AM Atisss hh <125atishprak@gmail.com>wrote: > > > On Sat, 7 Nov 2026 at 06:54, PG Bug reporting form > > wrote: > > The following bug has been logged on the website: > > Bug reference:      19839 > Logged by:          Atish Prakash > Email address: 125atishprak@gmail.com > PostgreSQL version: 18.6 > Operating system:   Linux x86_64 (kernel 7.0.0, glibc 2.43) > Description: > > On an assert-enabled build, logical decoding can fail this assertion and > take > the server through crash recovery: > >     TRAP: failed Assert("XLogRecPtrIsValid(txn->final_lsn)"), File: > "reorderbuffer.c", Line: 5001 > > Expected: decoding discards the aborted transaction and continues. > > The sequence is: > > 1. A transaction has a subtransaction with an XID but no decoded > changes, > for >    example one that only ran SELECT ... FOR UPDATE. > 2. The parent exceeds logical_decoding_work_mem while still in progress. >    ReorderBufferSerializeTXN() recurses into the subtransaction, writes > nothing, >    and still sets RBTXN_IS_SERIALIZED on it. Its final_lsn stays > invalid. > 3. The parent aborts while the decoder is behind. > 4. The parent is chosen for eviction before its abort record is decoded. >    ReorderBufferCheckAndTruncateAbortedTXN() finds it aborted and > truncates > it, >    and ReorderBufferRestoreCleanup() fails on the subtransaction's > final_lsn. > > ReorderBufferCheckAndTruncateAbortedTXN() came in with 072ee847ad, so I > expect > 17 and earlier are not affected, but I have not tested them. Thanks for the report and patch. I think this issue affects can all supported branches (back to PG 14), and does not require an aborted transaction to reproduce. For example, if a top-level transaction has a subtransaction with an XID but no decoded changes, and then spills to disk while queuing a partial change (such as TOAST chunks), the empty subtransaction is marked RBTXN_IS_SERIALIZED with final_lsn == InvalidXLogRecPtr. Once the main table insert completes the partial change, ReorderBufferProcessPartialChange() streams the transaction via ReorderBufferStreamTXN(), and ReorderBufferTruncateTXN() -> ReorderBufferRestoreCleanup() hits the same assertion on the empty subtransaction. See the attachment for a test to reproduce this issue. (Feel free to merge if it's worth adding a test to cover this path) > > From reading the code, a non-assert build goes through an empty > cleanup loop > for > this subtransaction, so I expect no user-visible effect there. I > have not > run a > non-assert build. I think in a rare case, this can also affect the stats collection for spilled txns. For example, if an empty subtransaction is marked as serialized, we skip incrementing spillTxns because no changes were written; if real changes are later serialized in this subtransaction, we still do not increment spillTxns because the subtransaction is already marked as serialized and we avoid counting it "twice". > > Proposed fix, attached as 0001-fix-aborted-spilled-txn-assert.patch: set > RBTXN_IS_SERIALIZED only if something was written. And I have one minor comment for the patch: + if (spilled) + txn->txn_flags |= RBTXN_IS_SERIALIZED; ReorderBufferSerializeTXN() already has an "if (spilled)" block right above this, so we shall directly move the assignment into that block. -- Best Regards, Zhijie Hou --------------kC07iR0F9VoMzarBg04gCi98 Content-Type: text/plain; charset=UTF-8; name="nocfbot-0001-Top-up-for-0001-Add-regression-test-for-spilled-txn-.patch" Content-Disposition: attachment; filename*0="nocfbot-0001-Top-up-for-0001-Add-regression-test-for-spilled"; filename*1="-txn-.patch" Content-Transfer-Encoding: base64 RnJvbSBkNTc0NjYxMjRmNjZlZDI3NmI3YWIxZjAwOWZhNjU5YmQ5OTg3NDU0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBaaGlqaWUgSG91IDxob3V6aGlqaWUyMkBnbWFpbC5j b20+CkRhdGU6IFN1biwgOCBOb3YgMjAyNiAyMjo0NDoxOSArMDgwMApTdWJqZWN0OiBbUEFU Q0hdIFRvcC11cCBmb3IgMDAwMTogQWRkIHJlZ3Jlc3Npb24gdGVzdCBmb3Igc3BpbGxlZCB0 eG4gd2l0aAogZW1wdHkgc3VieGFjdAoKQXV0aG9yOiBaaGlqaWUgSG91IDxob3V6aGlqaWUy MkBnbWFpbC5jb20+Ci0tLQogY29udHJpYi90ZXN0X2RlY29kaW5nL2V4cGVjdGVkL3N0cmVh bS5vdXQgfCAyNCArKysrKysrKysrKysrKysrKysrKysrKwogY29udHJpYi90ZXN0X2RlY29k aW5nL3NxbC9zdHJlYW0uc3FsICAgICAgfCAxNSArKysrKysrKysrKysrKwogMiBmaWxlcyBj aGFuZ2VkLCAzOSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvY29udHJpYi90ZXN0X2Rl Y29kaW5nL2V4cGVjdGVkL3N0cmVhbS5vdXQgYi9jb250cmliL3Rlc3RfZGVjb2RpbmcvZXhw ZWN0ZWQvc3RyZWFtLm91dAppbmRleCAwZWM1YzkzMzYxMC4uOWMxNjQ4NDdiMDMgMTAwNjQ0 Ci0tLSBhL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9zdHJlYW0ub3V0CisrKyBi L2NvbnRyaWIvdGVzdF9kZWNvZGluZy9leHBlY3RlZC9zdHJlYW0ub3V0CkBAIC0xNTcsNiAr MTU3LDMwIEBAIFNFTEVDVCBkYXRhIEZST00gcGdfbG9naWNhbF9zbG90X2dldF9jaGFuZ2Vz KCdyZWdyZXNzaW9uX3Nsb3QnLCBOVUxMLCBOVUxMLCAnaW5jCiAgQ09NTUlUCiAoMyByb3dz KQogCistLSBidWcgIzE5ODM5CistLQorLS0gQSBzdWJ0cmFuc2FjdGlvbiB3aXRob3V0IGRl Y29kZWQgY2hhbmdlcyBtdXN0IG5vdCBiZSBtYXJrZWQgYXMgc2VyaWFsaXplZAorLS0gd2hl biBpdHMgcGFyZW50IHRyYW5zYWN0aW9uIHNwaWxscyB0byBkaXNrIGR1cmluZyBhIHBhcnRp YWwgVE9BU1QgY2hhbmdlCistLSAoc3RyZWFtX3Rlc3QuZGF0YSBoYXMgRVhURVJOQUwgc3Rv cmFnZSBzZXQgYWJvdmUpLiAgT3RoZXJ3aXNlLCB0cnVuY2F0aW5nCistLSB0aGUgdHJhbnNh Y3Rpb24gYWZ0ZXIgc3RyZWFtaW5nIGZhaWxzIG9uIHRoZSBzdWJ0cmFuc2FjdGlvbidzIGlu dmFsaWQKKy0tIGZpbmFsX2xzbi4KK0JFR0lOOworU0FWRVBPSU5UIHM7CitTRUxFQ1QgMSBG Uk9NIHN0cmVhbV90ZXN0IExJTUlUIDEgRk9SIFVQREFURTsKKyA/Y29sdW1uPyAKKy0tLS0t LS0tLS0KKyAgICAgICAgMQorKDEgcm93KQorCitSRUxFQVNFIFNBVkVQT0lOVCBzOworSU5T RVJUIElOVE8gc3RyZWFtX3Rlc3QgVkFMVUVTIChyZXBlYXQoJ2EnLCAxMDAwMDApKTsKK0NP TU1JVDsKK1NFTEVDVCBjb3VudCgqKSBGUk9NIHBnX2xvZ2ljYWxfc2xvdF9nZXRfY2hhbmdl cygncmVncmVzc2lvbl9zbG90JywgTlVMTCwgTlVMTCwgJ2luY2x1ZGUteGlkcycsICcwJywg J3NraXAtZW1wdHkteGFjdHMnLCAnMScsICdzdHJlYW0tY2hhbmdlcycsICcxJyk7CisgY291 bnQgCistLS0tLS0tCisgICAgIDQKKygxIHJvdykKKwogRFJPUCBUQUJMRSBzdHJlYW1fdGVz dDsKIFNFTEVDVCBwZ19kcm9wX3JlcGxpY2F0aW9uX3Nsb3QoJ3JlZ3Jlc3Npb25fc2xvdCcp OwogIHBnX2Ryb3BfcmVwbGljYXRpb25fc2xvdCAKZGlmZiAtLWdpdCBhL2NvbnRyaWIvdGVz dF9kZWNvZGluZy9zcWwvc3RyZWFtLnNxbCBiL2NvbnRyaWIvdGVzdF9kZWNvZGluZy9zcWwv c3RyZWFtLnNxbAppbmRleCA1ZTQ1YThlOWI2NC4uZjMxNTkzMzU1NjQgMTAwNjQ0Ci0tLSBh L2NvbnRyaWIvdGVzdF9kZWNvZGluZy9zcWwvc3RyZWFtLnNxbAorKysgYi9jb250cmliL3Rl c3RfZGVjb2Rpbmcvc3FsL3N0cmVhbS5zcWwKQEAgLTgyLDUgKzgyLDIwIEBAIFJPTExCQUNL OwogSU5TRVJUIElOVE8gc3RyZWFtX3Rlc3QgVkFMVUVTICgnYWZ0ZXItYWJvcnQnKTsKIFNF TEVDVCBkYXRhIEZST00gcGdfbG9naWNhbF9zbG90X2dldF9jaGFuZ2VzKCdyZWdyZXNzaW9u X3Nsb3QnLCBOVUxMLCBOVUxMLCAnaW5jbHVkZS14aWRzJywgJzAnLCAnc2tpcC1lbXB0eS14 YWN0cycsICcxJyk7CiAKKy0tIGJ1ZyAjMTk4MzkKKy0tCistLSBBIHN1YnRyYW5zYWN0aW9u IHdpdGhvdXQgZGVjb2RlZCBjaGFuZ2VzIG11c3Qgbm90IGJlIG1hcmtlZCBhcyBzZXJpYWxp emVkCistLSB3aGVuIGl0cyBwYXJlbnQgdHJhbnNhY3Rpb24gc3BpbGxzIHRvIGRpc2sgZHVy aW5nIGEgcGFydGlhbCBUT0FTVCBjaGFuZ2UKKy0tIChzdHJlYW1fdGVzdC5kYXRhIGhhcyBF WFRFUk5BTCBzdG9yYWdlIHNldCBhYm92ZSkuICBPdGhlcndpc2UsIHRydW5jYXRpbmcKKy0t IHRoZSB0cmFuc2FjdGlvbiBhZnRlciBzdHJlYW1pbmcgZmFpbHMgb24gdGhlIHN1YnRyYW5z YWN0aW9uJ3MgaW52YWxpZAorLS0gZmluYWxfbHNuLgorQkVHSU47CitTQVZFUE9JTlQgczsK K1NFTEVDVCAxIEZST00gc3RyZWFtX3Rlc3QgTElNSVQgMSBGT1IgVVBEQVRFOworUkVMRUFT RSBTQVZFUE9JTlQgczsKK0lOU0VSVCBJTlRPIHN0cmVhbV90ZXN0IFZBTFVFUyAocmVwZWF0 KCdhJywgMTAwMDAwKSk7CitDT01NSVQ7CitTRUxFQ1QgY291bnQoKikgRlJPTSBwZ19sb2dp Y2FsX3Nsb3RfZ2V0X2NoYW5nZXMoJ3JlZ3Jlc3Npb25fc2xvdCcsIE5VTEwsIE5VTEwsICdp bmNsdWRlLXhpZHMnLCAnMCcsICdza2lwLWVtcHR5LXhhY3RzJywgJzEnLCAnc3RyZWFtLWNo YW5nZXMnLCAnMScpOworCiBEUk9QIFRBQkxFIHN0cmVhbV90ZXN0OwogU0VMRUNUIHBnX2Ry b3BfcmVwbGljYXRpb25fc2xvdCgncmVncmVzc2lvbl9zbG90Jyk7Ci0tIAoyLjU0LjAgKEFw cGxlIEdpdC0xNTcpCgo= --------------kC07iR0F9VoMzarBg04gCi98--