User-Agent: Cyrus-JMAP/3.5.0-alpha0-1369-gd055fb5e7c-fm-20211018.002-gd055fb5e
Mime-Version: 1.0
Message-Id: <1ec02758-652e-48fa-afbf-c1d5ed5f06e2@www.fastmail.com>
In-Reply-To: <YW0mYDzpVhEjcbNp@paquier.xyz>
References: <17220-15d684c6c2171a83@postgresql.org>
 <9b91d241-4d05-e5a4-67da-5b8acdb9a2f1@postgresfriends.org>
 <E29EF33B-CA1A-4146-BFCF-C8EC08FB91A8@amazon.com>
 <YWZViGJFJkrgBKwk@paquier.xyz>
 <CAFiTN-t9JSHmCtOtB_28BmAXEantUC2=1OKV_irAPAoxnzPadA@mail.gmail.com>
 <678CF71A-934B-4FD0-BF63-E41D795E41C9@amazon.com>
 <YWeQ2UXvXUH/Gt4T@paquier.xyz> <YW0mYDzpVhEjcbNp@paquier.xyz>
Date: Tue, 19 Oct 2021 08:48:05 +0200
From: "Matthijs van der Vleuten" <postgresql@zr40.nl>
To: "Michael Paquier" <michael@paquier.xyz>,
 "Bossart, Nathan" <bossartn@amazon.com>
Cc: "Dilip Kumar" <dilipbalaut@gmail.com>,
 "Vik Fearing" <vik@postgresfriends.org>,
 "Alexander Korotkov" <aekorotkov@gmail.com>,
 "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
 "Robert Haas" <robertmhaas@gmail.com>
Subject: Re: BUG #17220: ALTER INDEX ALTER COLUMN SET (..) with an optionless
 opclass
 makes index and table unusable
Content-Type: text/plain
Archived-At: 
 <https://www.postgresql.org/message-id/1ec02758-652e-48fa-afbf-c1d5ed5f06e2%40www.fastmail.com>
Precedence: bulk

On Mon, Oct 18, 2021, at 09:46, Michael Paquier wrote:
> On Thu, Oct 14, 2021 at 11:07:21AM +0900, Michael Paquier wrote:
> Attached is the patch I am finishing with, that should go down to
> v13 (this is going to conflict on REL_13_STABLE, for sure).
>
> Thoughts?

The test case doesn't seem entirely correct to me? The index being dropped (btree_tall_tbl_idx2) doesn't exist.

Also, I don't believe this tests the case of dropping the index when it previously has been altered in this way.