Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1epg2T-0007TR-TQ for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Feb 2018 20:03:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1epg2S-0005kl-Kx for pgsql-bugs@arkaria.postgresql.org; Sat, 24 Feb 2018 20:03:20 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1epg2S-0005kW-Bz for pgsql-bugs@lists.postgresql.org; Sat, 24 Feb 2018 20:03:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1epg2P-0005U3-J9; Sat, 24 Feb 2018 20:03:19 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w1OK3EGT020054; Sat, 24 Feb 2018 15:03:14 -0500 From: Tom Lane To: Michael Meskes cc: Andrew Gierth , jallen@americansavingslife.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15080: ecpg on windows doesn't define HAVE_LONG_LONG_INT In-reply-to: <1519501766.2510.13.camel@postgresql.org> References: <151935568942.1461.14623890240535309745@wrigleys.postgresql.org> <1519483386.2654.291.camel@postgresql.org> <877er2nr8c.fsf@news-spur.riddles.org.uk> <1519501766.2510.13.camel@postgresql.org> Comments: In-reply-to Michael Meskes message dated "Sat, 24 Feb 2018 20:49:26 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <20052.1519502594.1@sss.pgh.pa.us> Date: Sat, 24 Feb 2018 15:03:14 -0500 Message-ID: <20053.1519502594@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Michael Meskes writes: >> Solution.pm has this: >> ... >> from which HAVE_LONG_LONG_INT seems to be suspiciously missing? > Right, but it is missing in pg_config.h, too, right? No, it does get defined on Unix builds (if appropriate), both in pg_config.h and ecpg_config.h. As far as I can see in a quick grep, the core code doesn't use that symbol anywhere anyway ... but ecpg does. It's the fact that ecpg_config.h gets the symbol defined on Unix builds but not MSVC builds that Andrew is on about. regards, tom lane