From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: jazz001319@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #17886: Error disabling user triggers on a partitioned table
In-reply-to: <20230405073356.boweefqo5ec4dfhe@alvherre.pgsql>
References: <20230405073356.boweefqo5ec4dfhe@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 05 Apr 2023 09:33:56 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <2005409.1680713849.1@sss.pgh.pa.us>
Date: Wed, 05 Apr 2023 12:57:29 -0400
Message-ID: <2005410.1680713849@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/2005410.1680713849%40sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> On 2023-Apr-04, Tom Lane wrote:
>> I'm inclined to think that in the older branches (pre f4566345c)
>> we need to do
>> -       if (oldtrig->tgisinternal)
>> +       if (oldtrig->tgisinternal && !OidIsValid(oldtrig->tgparentid))
>> but I've not tested that.  Alvaro, what do you think?

> Oh, that's a nice and clean solution.  I tested it (on 13 and 14) and it
> does solve the problem, and no regression tests fail, but I didn't try
> to break it further.  12 and back are unaffected, for lack of
> 86f575948c77.

Pushed, thanks for looking at it.

			regards, tom lane