Date: Fri, 13 Jun 2014 15:14:12 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Andres Freund <andres@2ndquadrant.com>,
 PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around multixacts
Message-ID: <20140613191412.GP18688@eldon.alvh.no-ip.org>
References: <20140530121631.GE25431@alap3.anarazel.de>
 <20140530132916.GM28490@momjian.us>
 <20140530133244.GG25431@alap3.anarazel.de>
 <20140530150006.GP28490@momjian.us>
 <20140530151317.GB1220@awork2.anarazel.de>
 <20140530203515.GS28490@momjian.us>
 <20140530210353.GI30516@awork2.anarazel.de>
 <20140530212526.GT28490@momjian.us>
 <20140604085314.GA19423@momjian.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20140604085314.GA19423@momjian.us>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Bruce Momjian wrote:

> It appears this item is on hold until Alvaro can comment.  I can
> probably find the impact and correct the problem for previous upgrades,
> but it might be 1-2 months until I can get to it.  The fix for future
> upgrades is simple.

TBH I think future upgrades is what we need to fix now, so that people
don't do broken upgrades from 9.2 to 9.4 once the latter is out.  (I
would assume that upgrades from 9.3 will not have a problem, unless the
9.3 setup itself is already broken due to a prior pg_upgrade).  Also, we
need to fix pg_upgrade to protect people upgrading to 9.3.5 from <= 9.2.

As for detecting the case in existing installs, I think we can supply a
query in the next minor release notes that uses pg_ls_dir() to see
whether there is a 0000 file outside the working range of
multixact/offset, whose result if nonempty would indicate the need to
delete (or more likely rename) a file.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs