Date: Fri, 20 Jun 2014 14:09:18 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@2ndquadrant.com>,
 PostgreSQL Bugs <pgsql-bugs@postgresql.org>
Subject: Re: pg_upgrade < 9.3 -> >=9.3 misses a step around
 multixacts
Message-ID: <20140620180918.GE29143@momjian.us>
References: <20140619020633.GA20469@momjian.us>
 <20140619015205.GD3806@momjian.us>
 <20140619014034.GC3806@momjian.us>
 <20140619220425.GQ18688@eldon.alvh.no-ip.org>
 <20140619221240.GC27747@eldon.alvh.no-ip.org>
 <20140620171915.GC29143@momjian.us>
 <20140620173351.GV18688@eldon.alvh.no-ip.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20140620173351.GV18688@eldon.alvh.no-ip.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On Fri, Jun 20, 2014 at 01:33:52PM -0400, Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > On Thu, Jun 19, 2014 at 06:12:41PM -0400, Alvaro Herrera wrote:
> > > BTW I hacked up pg_resetxlog a bit to make it generate the necessary
> > > pg_multixact/offset file when -m is given.  This is not acceptable for
> > > commit because it duplicates the #defines from pg_multixact.c, but maybe
> > > we want this functionality enough that we're interested in a more
> > > complete version of this patch; also it unconditionally writes one zero
> > > byte to the file, which is of course wrong if the file exists and
> > > already contains data.
> > 
> > Why would we want this if the system functions fine without those files
> > being created?  I don't think we want pg_resetxlog to be doing anything
> > except changing pg_controldata.
> 
> I don't understand why you say the system functions fine.  If you move
> the multixactid with pg_resetxlog to a point which doesn't have the
> necessary file and page, the system will not start.  Only pg_upgrade
> knows to create the file appropriately, but normal operation doesn't.

True, but who would change the multi-xact except pg_upgrade, and would
you want pg_resetxlog to be changing other files in the file system,
perhaps as part of some disaster recovery operation?

The larger question is whether the backend code should more cleanly
handle such cases.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + Everyone has their own god. +


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs