Date: Thu, 24 Jul 2014 23:57:43 +0200
From: Andres Freund <andres@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: s.zuban@gmail.com, pgsql-bugs@postgresql.org
Subject: Re: BUG #11032: Prepared transactions do not update
 pg_last_xact_replay_timestamp() anymore
Message-ID: <20140724215743.GG16857@alap3.anarazel.de>
References: <20140724191127.32089.82261@wrigleys.postgresql.org>
 <20429.1406238373@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20429.1406238373@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 2014-07-24 17:46:13 -0400, Tom Lane wrote:
> s.zuban@gmail.com writes:
> > After upgrade from 9.3.4 to 9.3.5 pg_last_xact_replay_timestamp() returns
> > outdated timestamp.
> 
> > It stopped working properly after commit 
> > d19bd29f07aef9e508ff047d128a4046cc8bc1e2
> 
> Really?
> 
> It looks to me like this never worked: the code around recoveryStopsHere
> has never paid any attention to COMMIT_PREPARED (or ABORT_PREPARED).
> Certainly that patch had zip to do with the replay-timestamp behavior.
> 
> If you think it worked before, I'd like to see what your test case was.

I wonder if this is possibly influenced by
bb38fb0d43c8d7ff54072bfd8bd63154e536b384. IIRC before it committing a
prepared xact caused a plain commit record for the xid doing the COMMIT
PREPARED.

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs