Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-bugs-owner+M39287=pgsql+2Dbugs=arkaria.postgresql.org@postgresql.org>)
 id 1XBlkb-0000sH-2D
 for pgsql-bugs@arkaria.postgresql.org; Mon, 28 Jul 2014 14:18:05 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.80) (envelope-from
 <pgsql-bugs-owner+M39287=pgsql+2Dbugs=arkaria.postgresql.org@postgresql.org>)
 id 1XBlka-0007gn-II
 for pgsql-bugs@arkaria.postgresql.org; Mon, 28 Jul 2014 14:18:04 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.80) (envelope-from <andres@2ndquadrant.com>)
 id 1XBlkZ-0007gg-EP
 for pgsql-bugs@postgresql.org; Mon, 28 Jul 2014 14:18:03 +0000
Received: from mail.anarazel.de ([217.115.131.40])
 by makus.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <andres@2ndquadrant.com>) id 1XBlkV-0001Td-W1
 for pgsql-bugs@postgresql.org; Mon, 28 Jul 2014 14:18:01 +0000
Received: from intern.anarazel.de (p5DDC6A23.dip0.t-ipconnect.de
 [93.220.106.35]) (Authenticated sender: andres@anarazel.de)
 by mail.anarazel.de (Postfix) with ESMTPSA id B22DD500001;
 Mon, 28 Jul 2014 16:17:57 +0200 (CEST)
Date: Mon, 28 Jul 2014 16:17:57 +0200
From: Andres Freund <andres@2ndquadrant.com>
To: Heikki Linnakangas <hlinnakangas@vmware.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, s.zuban@gmail.com, pgsql-bugs@postgresql.org
Subject: Re: BUG #11032: Prepared transactions do not update
 pg_last_xact_replay_timestamp() anymore
Message-ID: <20140728141757.GN17793@alap3.anarazel.de>
References: <20140724191127.32089.82261@wrigleys.postgresql.org>
 <20429.1406238373@sss.pgh.pa.us>
 <20140724215743.GG16857@alap3.anarazel.de>
 <21266.1406241129@sss.pgh.pa.us>
 <20140724223459.GI16857@alap3.anarazel.de>
 <21620.1406242232@sss.pgh.pa.us> <53D62059.6060304@vmware.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53D62059.6060304@vmware.com>
X-Pg-Spam-Score: -2.6 (--)
List-Archive: <http://archives.postgresql.org/pgsql-bugs>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-bugs.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@postgresql.org>
List-Post: <mailto:pgsql-bugs@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-bugs>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-bugs>
X-Mailing-List: pgsql-bugs
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 2014-07-28 13:05:13 +0300, Heikki Linnakangas wrote:
> We probably should set XLogRecord->xl_xid in COMMIT_/ABORT_PREPARED records
> though. It seems weird not to, and it would simplify code that interprets
> those records. But I don't think we should back-patch that.

I doubt that'd be a net improvement - wouldn't that just make the life
of anything tracking xid liveliness a bit more complicated?

Greetings,

Andres Freund

-- 
 Andres Freund	                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs