Received: from malur.postgresql.org ([217.196.149.56])
 by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from
 <pgsql-hackers-owner+M284342=pgsql-hackers-arkari@postgresql.org>)
 id 1Zt894-0000yl-Lp
 for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Nov 2015 05:59:06 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
 by malur.postgresql.org with smtp (Exim 4.84) (envelope-from
 <pgsql-hackers-owner+M284342=pgsql-hackers-arkari@postgresql.org>)
 id 1Zt893-00025c-U9
 for pgsql-hackers@arkaria.postgresql.org; Mon, 02 Nov 2015 05:59:05 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
 by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
 (Exim 4.84) (envelope-from <jeff.janes@gmail.com>)
 id 1Zt893-00025S-C5
 for pgsql-hackers@postgresql.org; Mon, 02 Nov 2015 05:59:05 +0000
Received: from mahout.postgresql.org ([2001:4800:1501:1::227])
 by makus.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256)
 (Exim 4.84) (envelope-from <jeff.janes@gmail.com>)
 id 1Zt890-0008Ng-Ea
 for pgsql-hackers@postgresql.org; Mon, 02 Nov 2015 05:59:03 +0000
Received: from coridan.postgresql.org ([2001:4800:1501:1::213])
 by mahout.postgresql.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256)
 (Exim 4.80) (envelope-from <jeff.janes@gmail.com>)
 id 1Zt890-00022m-5y
 for pgsql-hackers@postgresql.org; Mon, 02 Nov 2015 05:59:02 +0000
Received: from localhost ([127.0.0.1] helo=coridan.postgresql.org)
 by coridan.postgresql.org with esmtp (Exim 4.80)
 (envelope-from <jeff.janes@gmail.com>) id 1Zt88z-00008u-JF
 for pgsql-hackers@postgresql.org; Mon, 02 Nov 2015 05:59:01 +0000
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: BUG #13685: Archiving while idle every archive_timeout with
 wal_level hot_standby
To: pgsql-hackers@postgresql.org
From: Jeff Janes <jeff.janes@gmail.com>
Date: Mon, 02 Nov 2015 05:58:41 +0000
User-Agent: pgcommitfest
X-cfsender: jjanes
In-Reply-To: 
 <CAB7nPqS-joTOdjqBUYGdawVcOw5UwrMZf+vOdzzbgHtDBg6SRg@mail.gmail.com>
References: <20151016203031.3019.72930@wrigleys.postgresql.org>
 <CAB7nPqS-joTOdjqBUYGdawVcOw5UwrMZf+vOdzzbgHtDBg6SRg@mail.gmail.com>
Message-ID: <20151102055841.2561.61366.pgcf@coridan.postgresql.org>
X-Pg-Spam-Score: -5.3 (-----)
List-Archive: <http://archives.postgresql.org/pgsql-hackers>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-hackers.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@postgresql.org>
List-Post: <mailto:pgsql-hackers@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-hackers>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
X-Mailing-List: pgsql-hackers
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

The following review has been posted through the commitfest application:
make installcheck-world:  tested, passed
Implements feature:       tested, passed
Spec compliant:           not tested
Documentation:            not tested

Simple patch, applies and makes cleanly, does what it says and says what it does.

If a transaction holding locks aborts on an otherwise idle server, perhaps it will take a very long time for a log-shipping standby to realize this.  But I have hard time believing that anyone who cares about that would be using log-shipping (rather than streaming) anyway.

Marking it ready for committer.

The new status of this patch is: Ready for Committer


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers