Date: Mon, 2 Nov 2015 16:26:26 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Haribabu Kommi <kommi.haribabu@gmail.com>, brown@fastmail.com,
 "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Subject: Re: BUG #13741: vacuumdb does not accept valid password
Message-ID: <20151102192626.GG6104@alvherre.pgsql>
References: <20151027193919.931.54948@wrigleys.postgresql.org>
 <CAJrrPGeQQ1rCuTbgaeMuuV-bFwp=xDZQkYOZ-AEb2yUqHFXYVg@mail.gmail.com>
 <CAJrrPGeK5BLEpEgfApDN64aKyH1akm+GLxvmcFK-4dvSuF=p-g@mail.gmail.com>
 <CAJrrPGeVyCxrDUAG6RCZOcYCv8+-pKHLVWiHoU0tHzE0YYX8UQ@mail.gmail.com>
 <CAB7nPqRbAWHx23L_hJiN+GTJu6EJ_VEYX1s=5BBtVvYdSaywMA@mail.gmail.com>
 <CAB7nPqR8h98JM-k0NM-DPpf=zrBDjtg4-poqr0ppwiX4pS7sVw@mail.gmail.com>
 <CAJrrPGcZDq-ts3Yx8SyRvKY5s+MTzDmXCL5WM3OQU56fvCcQSA@mail.gmail.com>
 <CAB7nPqQOianRojz+_=kdYg4caeYuP9057ODTgCFoAHSp0t9ccw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAB7nPqQOianRojz+_=kdYg4caeYuP9057ODTgCFoAHSp0t9ccw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Michael Paquier wrote:
> On Mon, Nov 2, 2015 at 8:10 PM, Haribabu Kommi wrote:
> > Here I attached modified patch that gets the password from parent connection
> > if exists and use it for the child connection also.
> 
> Meh? Why the parent connection? You could simply have the password as
> an argument of connectDatabase, per se the attached. That looks just
> more simple.

Thanks!  This is almost there, but there's an important missing piece --
vacuumdb --all will ask you for a password for each database.  I think
vacuum_one_database needs to receive a password from its caller too.

(Also, please use pg_strdup.)

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs