Date: Thu, 12 Nov 2015 18:58:41 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fujii Masao <masao.fujii@gmail.com>,
 Michael Paquier <michael.paquier@gmail.com>,
 Haribabu Kommi <kommi.haribabu@gmail.com>, brown@fastmail.com,
 "pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>
Subject: Re: BUG #13741: vacuumdb does not accept valid password
Message-ID: <20151112215841.GS614468@alvherre.pgsql>
References: 
 <CAJrrPGeXuav-OYjJYKwSaLt+aOU+emH4a5XZS3XfMHNfanUmnw@mail.gmail.com>
 <CAJrrPGetAZVhE=0YJY5idTYtSt2o1LCkkC9aQaw81kJg2RyWuw@mail.gmail.com>
 <20151104021618.GP6104@alvherre.pgsql>
 <CAB7nPqSazOE_bB7koqHOY2gYM6vPs9e3D158ZCjxyJ61p1Ra8Q@mail.gmail.com>
 <CAB7nPqTq5PfQbMMCqJ4KRM8Q1ppOgVu4WziuEzm=3TNUN5wUoA@mail.gmail.com>
 <CAHGQGwHx0BvxTDpo2xXS--gEJFQjjrTP4BZY8wRzUfPYakzEgQ@mail.gmail.com>
 <20151112170303.GN614468@alvherre.pgsql>
 <15139.1447357263@sss.pgh.pa.us>
 <20151112212627.GR614468@alvherre.pgsql>
 <21797.1447365082@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <21797.1447365082@sss.pgh.pa.us>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > Thanks for the input.  I decided to push what we had because it's less
> > invasive in terms of API definition.
> 
> I dunno, this might be easier for the callers that don't want password
> re-use, but it seems quite horrid for ones that do.  The changes to
> vacuumdb.c are, frankly, seriously ugly; and they require vacuumdb.c
> to know a lot more than before about password handling.

Yes, it is ugly.

> Other notes are that the strdup() call should surely be pg_strdup(),
> and the mix of free() and pg_free() is at best unsightly.

I had the same comment, but it turns out that free and strdup must be
used instead because sprompt.c uses malloc in the equivalent places; and
we can't use pg_malloc there because it's in src/port which isn't
allowed to use fe_memutils.  We would have to move it from src/port to
src/common first.

> The place I was thinking we might end up was something like Fujii-san's
> patch plus a new bool parameter "allow_password_reuse", which could be
> passed as false in cases where the old behavior seems preferable.

Hm, we can try that.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs