Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKYOd-0001L5-1J for pgsql-bugs@arkaria.postgresql.org; Tue, 05 Jul 2016 22:00:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bKYOc-0006xb-FU for pgsql-bugs@arkaria.postgresql.org; Tue, 05 Jul 2016 22:00:46 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bKYOb-0006wy-05 for pgsql-bugs@postgresql.org; Tue, 05 Jul 2016 22:00:45 +0000 Received: from smtprelay0210.b.hostedemail.com ([64.98.42.210] helo=smtprelay.b.hostedemail.com) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bKYOS-0002xN-AE for pgsql-bugs@postgresql.org; Tue, 05 Jul 2016 22:00:43 +0000 Received: from filter.hostedemail.com (10.5.19.248.rfc1918.com [10.5.19.248]) by smtprelay06.b.hostedemail.com (Postfix) with ESMTP id ED61D8D273; Tue, 5 Jul 2016 22:00:34 +0000 (UTC) X-Session-Marker: 616C76686572726540616C76682E6E6F2D69702E6F7267 X-Spam-Summary: 50,0,0,,d41d8cd98f00b204,alvherre@alvh.no-ip.org,:::::::,RULES_HIT:41:327:355:379:599:871:967:973:988:989:1260:1263:1311:1312:1313:1314:1345:1359:1437:1515:1516:1518:1519:1539:1575:1594:1595:1596:1711:1730:1747:1764:1777:1792:2393:2525:2560:2563:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3352:3865:3866:3867:3868:3871:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4605:4659:5007:6261:6748:7281:7398:7901:8957:9025:9121:10004:10400:10471:10848:11256:11257:11604:11658:11914:12438:12517:12519:12663:13255:13439:13848:13894:13895:14658:14659:21080:21212:21324:30012:30029:30054:30070:30080:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:7,LUA_SUMMARY:none X-HE-Tag: bite54_4ea87a845f02 X-Filterd-Recvd-Size: 35305 Received: from alvin.alvh.no-ip.org (unknown [216.155.90.98]) (Authenticated sender: alvherre@alvh.no-ip.org) by omf09.b.hostedemail.com (Postfix) with ESMTPA; Tue, 5 Jul 2016 22:00:33 +0000 (UTC) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 9D5CB52B; Tue, 5 Jul 2016 18:00:31 -0400 (CLT) Date: Tue, 5 Jul 2016 18:00:31 -0400 From: Alvaro Herrera To: Olivier Dony Cc: Kevin Grittner , Olivier Dony , "pgsql-bugs@postgresql.org" Subject: Re: BUG #13681: Serialization failures caused by new multixact code of 9.3 (back-patch request) Message-ID: <20160705220031.GA602524@alvherre.pgsql> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="T4sUOijqQbZv57TR" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-Pg-Spam-Score: -0.4 (/) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-bugs Precedence: bulk Sender: pgsql-bugs-owner@postgresql.org --T4sUOijqQbZv57TR Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit I'm looking at this open bug again. I attach two commits; the first one adds two test cases illustrating the current (broken) behavior, and the second one adds the fix and changes the test cases to match the new behavior. I spent a lot of time trying to find (a) any other HeapTupleSatisfiesUpdate caller that needed to be changed, and (b) additional test cases that showed misbehavior, and so far I haven't been able to come up with any. No other test case is affected AFAICS. I intend to push this and backpatch to 9.3. -- Álvaro Herrera http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services --T4sUOijqQbZv57TR Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-test-cases.patch"