Date: Fri, 16 Dec 2016 11:43:51 -0300
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: hlinnaka@iki.fi
Cc: pgsql-bugs@postgresql.org
Subject: Re: BUG #14468: One byte buffer overlow in
 quote_literal_cstr()
Message-ID: <20161216144351.apdbuk4je5ywekle@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20161216105001.13334.42819@wrigleys.postgresql.org>
User-Agent: NeoMutt/20161104 (1.7.1)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

hlinnaka@iki.fi wrote:

> Looking at quote_literal_cstr(), it simply doesn't take into account the
> space needed for the NULL terminator, when it allocates the buffer. The fix
> is a straightforward + 1 to the allocation. I'll go and do that shortly, and
> backpatch.

Hm, that's a bit confusing.  I thought the +3 included the terminator,
but what it's actually for is the optional starting E; and the reason
quote_literal doesn't need similar patching it is that there is no
terminator 'cause it produces varlena.  I would think this deserves a
comment ...

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs