Date: Tue, 20 Jun 2017 22:02:10 -0400
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Bruno Wolff III <bruno@wolff.to>, pgsql-bugs@postgresql.org
Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS
Message-ID: <20170621020210.eqf44aoqjcu3qtma@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="vkrsvmbh63hjngly"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20170621004237.GB8337@wolff.to>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org


--vkrsvmbh63hjngly
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Bruno Wolff III wrote:
> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF
> NOT EXISTS. Given this is new, maybe there is a bug in the parser.

You're absolutely right, and this is a bug in the parser -- I probably
misplaced the IF NOT EXISTS clause while playing with Tomas' parser
changes.  Here's the fix.  I'm a bit troubled that this change doesn't
seem to affect any tests, so I'll add some before pushing.

(Now, "statistics" being plural would seem to call for CREATE STATISTICS
IF NOT EXIST, rather than EXISTS, but I'll put that thought aside on
account of it being just too weird ...)

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--vkrsvmbh63hjngly
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
 filename="0001-fix-create-stats-grammar.patch"