Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dO5p0-0000xw-81 for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Jun 2017 17:23:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dO5oz-0002ou-Qo for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Jun 2017 17:23:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dO5oJ-0001Xr-2C for pgsql-bugs@postgresql.org; Thu, 22 Jun 2017 17:22:27 +0000 Received: from mail-qt0-x232.google.com ([2607:f8b0:400d:c0d::232]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1dO5oG-00089o-I0 for pgsql-bugs@postgresql.org; Thu, 22 Jun 2017 17:22:25 +0000 Received: by mail-qt0-x232.google.com with SMTP id u12so17213811qth.0 for ; Thu, 22 Jun 2017 10:22:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :content-transfer-encoding:in-reply-to:user-agent; bh=VZ5B0nk5gp9isCfDsIDi49VH5LltJz++KX1DFDMAdfs=; b=uj9MVvu9XS77UgfqR77qdXyUP6WzW2NEO2nbTzMxuEVVRaYxTCrYviIQbFAPpUCJ+J UTeeBlODwm/oIbD6DaQ28iq3IdZRfzk7G22ouVsxSRyXtbqO0U9mzb4UAJc1XKq68wpk e79vQbWXTrLuiZ0r7N4v5PV44SVmyvNAJgvyExqhA228t+xMjEQvomoCbKF3rPTXwoZT GrlecoWqFic/vVMOT/OiFvFrfU59f0b0N1bqV94tR6Dk8NjJOzobOmLK0F4mGdAZKPUs S7KydpiIEXRy7a40K4TM6mRbKx1TxEyhg9LeMnjtHt0MIOXPTtKputKrNUZcb5Sk7Xm4 GMgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=VZ5B0nk5gp9isCfDsIDi49VH5LltJz++KX1DFDMAdfs=; b=owwdZmVyvUzFM7Q22qXgC5baRjBasAsNf9kpZGPWiS1KVMoLovyGG9gbrbGJLEnWgv 4AZNeg7BbmxBwgw7V0MvMbxnbZMxNceRWobwrwvcXCyizIXRRkcO/nZ2wVJPl1acRUlY Th+0MEB/ft9dHpgoT/wGPB75LYnIVnAkm/7kO74QXUIVNGnKONtQ2hZ9GXTG5vyZ1OW1 qibFZUS/9lTAPJiIT18PeJgrFGmtK9dr15Lf3tMT7UQnj/tx3AmHi8shTGaMXAOVfwM5 QD7rljsc4ERgafjOknh4qEygm4kNr1kcs+zvWKC9KXRTZxPo9Vn/n40kBb3nyZw0aN5D ErJQ== X-Gm-Message-State: AKS2vOwwjwbO4H6Dq4rivtLnHWsnikhdUxvE/b0c/IHVLgPLDGsMRw5A NLQk8RXpFrzuY1Nl X-Received: by 10.200.39.214 with SMTP id x22mr4498879qtx.80.1498152143621; Thu, 22 Jun 2017 10:22:23 -0700 (PDT) Received: from alvin.alvh.no-ip.org ([179.57.115.10]) by smtp.gmail.com with ESMTPSA id s12sm744943qtc.52.2017.06.22.10.22.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2017 10:22:23 -0700 (PDT) Received: by alvin.alvh.no-ip.org (Postfix, from userid 1000) id 6F6E36F3; Thu, 22 Jun 2017 13:22:21 -0400 (-04) Date: Thu, 22 Jun 2017 13:22:21 -0400 From: Alvaro Herrera To: Amit Langote Cc: Bruno Wolff III , pgsql-bugs@postgresql.org Subject: Re: Beta 10 parser error for CREATE STATISTICS IF NOT EXISTS Message-ID: <20170622172221.qmudrzomu6iolznr@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-bugs Precedence: bulk Sender: pgsql-bugs-owner@postgresql.org Amit Langote wrote: > On 2017/06/21 11:02, Alvaro Herrera wrote: > > Bruno Wolff III wrote: > >> I'm not seeing an obvious error in my attempt to use CREATE STATISTICS IF > >> NOT EXISTS. Given this is new, maybe there is a bug in the parser. > > > > You're absolutely right, and this is a bug in the parser -- I probably > > misplaced the IF NOT EXISTS clause while playing with Tomas' parser > > changes. Here's the fix. I'm a bit troubled that this change doesn't > > seem to affect any tests, so I'll add some before pushing. > > I posted the same patch but with a test: > > https://www.postgresql.org/message-id/38b7d52e-387a-0e47-7525-b8b654ca4bfb%40lab.ntt.co.jp Pushed. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs