Date: Mon, 14 Aug 2017 15:29:55 -0700
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>, Rushabh Lathia <rushabh.lathia@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, pgsql-bugs@postgresql.org
Subject: Re: [postgresql 10 beta3] unrecognized node type: 90
Message-ID: <20170814222955.sowcmnabfdgmlmdn@alap3.anarazel.de>
References: 
 <CAL7LBcYM-32B=n_-h_wPHWiML26UvqP3b_WxD7MgXgOwmxvTFw@mail.gmail.com>
 <11673.1502467154@sss.pgh.pa.us>
 <27200.1502482851@sss.pgh.pa.us>
 <20170811202629.3eebdnnv7osn5hqw@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170811202629.3eebdnnv7osn5hqw@alap3.anarazel.de>
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On 2017-08-11 13:26:29 -0700, Andres Freund wrote:
> On 2017-08-11 16:20:51 -0400, Tom Lane wrote:
> > I wrote:
> > > So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> > > to plug it into ExecReScan.  From which we may draw depressing conclusions
> > > about how much it's been tested.
> > 
> > While I'm bitching ... the code coverage report at
> > 
> > https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html
> > 
> > also leaves one with less than a warm feeling about the extent of test
> > coverage on this file.  heap_compare_slots isn't invoked even once?
> 
> I complained about this before at
> http://archives.postgresql.org/message-id/20170401022605.4wag26gtyzhny7ue%40alap3.anarazel.de
> but I just noticed that Rushabh appears to have sent a patch adding
> coverage. Missed that somehow, will apply.

And pushed (to both 10 and master).

- Andres


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs