Date: Wed, 6 Sep 2017 15:27:38 +0200
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>, "Wood, Dan" <hexpert@amazon.com>,
	"pgsql-bugs@postgresql.org" <pgsql-bugs@postgresql.org>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Old row version in hot chain become visible after a freeze
Message-ID: <20170906132738.2dpwvnfcuevjofhl@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="d55dqzl435awcqkx"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAB7nPqR73SHUrc6rnWJKGWUCjGiAmTpNLb6bc3T0gkRJa4Bh9g@mail.gmail.com>
User-Agent: NeoMutt/20170306-137-4415bd-dirty (1.8.0)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org


--d55dqzl435awcqkx
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Another thing is that if you're going through heap_copy_data, the tuple
is only checked for DEAD, not RECENTLY_DEAD.  Maybe there is no bug here
but I'm not sure yet.

I attach the patch as I have it now -- mostly comment tweaks, but also
the change to not mark page as all-frozen when we skip freezing a
recently read tuple.  I also renamed the test case, because I think it
may be possible to reach the problem code without involving a multixact.
Haven't tried too hard though.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

--d55dqzl435awcqkx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="0001-test-cases.patch"