Date: Tue, 26 Sep 2017 17:46:18 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>,
	"David E. Wheeler" <david@justatheory.com>,
	Christophe Pettus <christophe.pettus@pgexperts.com>,
	pgsql-bugs@postgresql.org, pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] BUG #14825: enum type: unsafe use?
Message-ID: <20170926214618.GC7167@momjian.us>
References: <27064.1506350579@sss.pgh.pa.us>
 <5f4f29bf-90b1-e49a-6cf9-069c59bc1067@2ndQuadrant.com>
 <40FDB1F3-932D-4912-B4C7-F1E26E331079@justatheory.com>
 <1090.1506365074@sss.pgh.pa.us>
 <9666.1506446327@sss.pgh.pa.us>
 <329.1506451066@sss.pgh.pa.us>
 <38835cdd-!c378-8d7a-013b-fd733c78c649@2ndQuadrant.com>
 <12792.1506456422@sss.pgh.pa.us>
 <20170926211419.GB7167@momjian.us>
 <16025.1506461535@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <16025.1506461535@sss.pgh.pa.us>
User-Agent: Mutt/1.5.23 (2014-03-12)
Precedence: bulk
Sender: pgsql-bugs-owner@postgresql.org

On Tue, Sep 26, 2017 at 05:32:15PM -0400, Tom Lane wrote:
> Bruce Momjian <bruce@momjian.us> writes:
> > On Tue, Sep 26, 2017 at 04:07:02PM -0400, Tom Lane wrote:
> >> Any other votes out there?
> 
> > Well, I was concerned yesterday that we had a broken build farm so close
> > to release. (I got consistent regression failures.)  I think PG 11 would
> > be better for this feature change, so I support reverting this.
> 
> I'll take the blame for (most of) yesterday's failures in the v10
> branch, but they were unrelated to this patch --- they were because
> of that SIGBUS patch I messed up.  So that doesn't seem like a very
> applicable argument.  Still, it's true that this seems like the most
> consequential patch that's gone into v10 post-RC1, certainly so if
> you discount stuff that was back-patched further than v10.

Oh, I couldn't untangle that the regression failures were unrelated to
enums, so please ignore my opinion.

-- 
  Bruce Momjian  <bruce@momjian.us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs