pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #14859: Config file parsing is allergic to spaces on last line of file
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2017-10-17 2ac5988747 9e20276e13 38f17e8eeb 06b2a73eda Fix misparsing of non-newline-terminated pg_hba.conf files.
* BUG #14859: Config file parsing is allergic to spaces on last line of file
@ 2017-10-17 14:18 boatcoder@gmail.com
2017-10-17 14:44 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 4+ messages in thread
From: boatcoder@gmail.com @ 2017-10-17 14:18 UTC (permalink / raw)
To: pgsql-bugs; +Cc: boatcoder@gmail.com
The following bug has been logged on the website:
Bug reference: 14859
Logged by: Mark Jones
Email address: boatcoder@gmail.com
PostgreSQL version: 9.5.9
Operating system: Ubuntu
Description:
Edit your pg_hba.conf file, add a space (without a new line) at the end of
the file.
Attempt to start postgres. It will fail with messages like this.
2017-10-17 13:20:22 UTC [2471-1] LOG: invalid connection type "ost"
2017-10-17 13:20:22 UTC [2471-2] CONTEXT: line 103 of configuration file
"/etc/postgresql/9.5/main/pg_hba.conf"
2017-10-17 13:20:22 UTC [2471-3] FATAL: could not load pg_hba.conf
Look at config file file, scratch head because space is hard to
detect.....
Finally figure it out. Wonder how that space got in there....
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #14859: Config file parsing is allergic to spaces on last line of file
2017-10-17 14:18 BUG #14859: Config file parsing is allergic to spaces on last line of file boatcoder@gmail.com
@ 2017-10-17 14:44 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-10-17 14:58 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 4+ messages in thread
From: Tom Lane @ 2017-10-17 14:44 UTC (permalink / raw)
To: boatcoder@gmail.com; +Cc: pgsql-bugs
boatcoder@gmail.com writes:
> Edit your pg_hba.conf file, add a space (without a new line) at the end of
> the file.
> Attempt to start postgres. It will fail with messages like this.
Hmph. I can reproduce this in 9.6 and earlier, but not in v10 or HEAD.
Apparently somebody fixed it by accident. Looking ...
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #14859: Config file parsing is allergic to spaces on last line of file
2017-10-17 14:18 BUG #14859: Config file parsing is allergic to spaces on last line of file boatcoder@gmail.com
2017-10-17 14:44 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file Tom Lane <tgl@sss.pgh.pa.us>
@ 2017-10-17 14:58 ` David G. Johnston <david.g.johnston@gmail.com>
2017-10-17 15:28 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 4+ messages in thread
From: David G. Johnston @ 2017-10-17 14:58 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-bugs
On Tue, Oct 17, 2017 at 7:44 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> boatcoder@gmail.com writes:
> > Edit your pg_hba.conf file, add a space (without a new line) at the end
> of
> > the file.
> > Attempt to start postgres. It will fail with messages like this.
>
> Hmph. I can reproduce this in 9.6 and earlier, but not in v10 or HEAD.
> Apparently somebody fixed it by accident. Looking ...
>
Probably as a side-effect of:
"Add view pg_hba_file_rules to display the contents of pg_hba.conf"
to v10 (you can probably find the commit hash faster than I).
David J.
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: BUG #14859: Config file parsing is allergic to spaces on last line of file
2017-10-17 14:18 BUG #14859: Config file parsing is allergic to spaces on last line of file boatcoder@gmail.com
2017-10-17 14:44 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file Tom Lane <tgl@sss.pgh.pa.us>
2017-10-17 14:58 ` Re: BUG #14859: Config file parsing is allergic to spaces on last line of file David G. Johnston <david.g.johnston@gmail.com>
@ 2017-10-17 15:28 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 4+ messages in thread
From: Tom Lane @ 2017-10-17 15:28 UTC (permalink / raw)
To: David G. Johnston <david.g.johnston@gmail.com>; +Cc: pgsql-bugs
"David G. Johnston" <david.g.johnston@gmail.com> writes:
> On Tue, Oct 17, 2017 at 7:44 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Hmph. I can reproduce this in 9.6 and earlier, but not in v10 or HEAD.
>> Apparently somebody fixed it by accident. Looking ...
> Probably as a side-effect of:
> "Add view pg_hba_file_rules to display the contents of pg_hba.conf"
> to v10 (you can probably find the commit hash faster than I).
Close, but apparently it was the adjacent commit 1e5a5d03d,
"Simplify some long-obsolete code in hba.c's next_token()."
in which I wrote
Also, ensure that we don't return with *lineptr set to someplace past the
terminating '\0'; that would be catastrophic if a caller were to ask for
another token from the same line. This is just latent since no callers
actually do call again after a "false" return; but considering that it was
actually costing us extra code to do it wrong, we might as well make it
bulletproof.
I was wrong to think that the problem was only latent, because
tokenize_file() decides whether there's more on the line using
while (strlen(lineptr) > 0)
so that having advanced lineptr past the current line's '\0' allows
it to see (and process) whatever had been in the buffer beyond that
from preceding line(s).
This seems to have been broken since 9.3; kinda surprising nobody
noticed earlier. I shall go back-patch 1e5a5d03d --- it does a bit
more than the minimum needed to fix the bug, but the other changes
seem harmless enough.
regards, tom lane
--
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2017-10-17 15:28 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-10-17 14:18 BUG #14859: Config file parsing is allergic to spaces on last line of file boatcoder@gmail.com
2017-10-17 14:44 ` Tom Lane <tgl@sss.pgh.pa.us>
2017-10-17 14:58 ` David G. Johnston <david.g.johnston@gmail.com>
2017-10-17 15:28 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox