Date: Mon, 5 Mar 2018 18:01:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>,
	TipTop Labs <office@tiptop-labs.com>,
	Michael Paquier <michael.paquier@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@postgresql.org>
Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control
Message-ID: <20180305090111.GI2266@paquier.xyz>
References: <20180104200633.17004.16377@wrigleys.postgresql.org>
 <CAB7nPqTyq3cjphJmoCPc0n8r90O4j1BpZC2BMaj8dKZ7g0-mtw@mail.gmail.com>
 <0D104D1E-6103-49F4-8AB8-B5CD92949E18@tiptop-labs.com>
 <20180115072537.GC1724@paquier.xyz>
 <D2684F73-AE17-453B-ACB5-9CF0A7F6856E@tiptop-labs.com>
 <20180227012441.GB3255@paquier.xyz>
 <CA+q6zcWeFmGc=uC5CwL7HznL25nCqh0CvepgtyuGQo1duStE+w@mail.gmail.com>
 <20180305075431.GH2266@paquier.xyz>
 <CAD21AoDiHUUguQ7UUyK_Z4icHM3OiP8OEkpgDCsT3fg3B-P2LA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="zH41lVBEV8cLJnCl"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoDiHUUguQ7UUyK_Z4icHM3OiP8OEkpgDCsT3fg3B-P2LA@mail.gmail.com>
Precedence: bulk


--zH41lVBEV8cLJnCl
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 05, 2018 at 05:47:06PM +0900, Masahiko Sawada wrote:
> Since files other than relation files such as vm, fsm, WAL are
> categorize as FILE_ACTION_COPY_CONFIG, I think the name would cause
> misreading. For example, we can use FILE_ACTION_COPY_DATA and
> FILE_ACTION_COPY_OTHER?

I am not stopped on a given name.

> As you mentioned before, with this patch we end up ignoring file-open
> error of database files other than relation files. I guess it's a bit
> risky. We can enter them to COPY_DATA but I'd defer it to committer.

COPY_DATA is aimed at being used on files which can be parsed by
blocks.  You cannot do that with VMs and FSMs.  Now you are true that we=20
could complain for non-configuration files which need to be
fully-copied, still Postgres issues a fsync on all the files of the data
folder when beginning recovery, so you would bump on problems anyway
after restarting the rewound instance.
--
Michael

--zH41lVBEV8cLJnCl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlqdB1cACgkQnvQgOdby
QH1Mgg/+OVIXXLrco/7sE+KfcRJleyegHz9JSkHgyo1Xn6+AuRvP+RBJG4qt0eCx
HJwWV2eCGqP7mGHJMaBaoaIFlV1dFmcgQ5fzu4bw3yArqzAFTfcxbyrvO2sQtAQ+
r+JnFMO4lCG9r/zOVWfKH2e3WYiGUTVc550K/DjyKawsLuwc7PfK3NopmSa4iVRH
pHpZilIRibHXPcjc4XjgIgX1uku/ok9U+C7l0AEScfrUd8JE5Tc9uZF/1YCayOUY
N+IHHnxmrAXbFoFqDFA7QZhRZwPyrfUG3YWCjYlkwH7FBaWJuI8f05fvRM58osut
SKaFDxoSJLNP8oGetNtd/2f2SVbYiUz5xkihmoNIfDzEIqYE7h6ittnQUt3m5Svr
hrKCuwiCac5Az2OCyTVjjvMKmxOMW+sIt7DwsjmWXtHm+tsrNUL+bSugv7NKMQCc
DgKqCVzCNJukRD7MDQmtIQr9kxqVW3XK3JAECM0UtmuBpk6ZSg7k7KByxslJ6rmn
k/bRXG/SxUtGwb/6XKqHDs0q3SFVUYeFtXLW5Tg9gpl7HDQ3nNLN4nvsRU3Tee3s
b43z7msO/T0DeEVwnZRbpZx3399/p4Jrq5g+ICZ0qizLT/Znla5R9Ms2ZykiYIUd
avNwns3EhZUL4BWl7oILa6tQ2JAlhNqZnVMlUJSZiCRkDE64iqI=
=9/qn
-----END PGP SIGNATURE-----

--zH41lVBEV8cLJnCl--