Received: from malur.postgresql.org ([2a02:16a8:dc51::56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXh3S-0006q0-7S for pgsql-bugs@arkaria.postgresql.org; Tue, 26 Jun 2018 06:02:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fXh3Q-0007NM-JL for pgsql-bugs@arkaria.postgresql.org; Tue, 26 Jun 2018 06:02:16 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXh3Q-0007N9-9w for pgsql-bugs@lists.postgresql.org; Tue, 26 Jun 2018 06:02:16 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fXh3J-0004wQ-Ph for pgsql-bugs@lists.postgresql.org; Tue, 26 Jun 2018 06:02:15 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 3016721E66; Tue, 26 Jun 2018 02:02:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 26 Jun 2018 02:02:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=At1UzgpZmWa1xfWRtVpAcCjRhv2dxEr7nDeMaj4S77g=; b=aLm6Zz35 eNhGKf68pCIcDrllNqlMioFv57iwH2hwJmjxRgKErqpRh3cUqkCzxpktkHAkfTKK KwCwhxu+sPGIvAsoaneQhQ6lfZrle3QnYUd13IFpoWRKSQfI0nTeF26cfaJ3eY6c cS5DgN25SpLHDHpUMqYHAIFpVKlIhBUhpLoDHohB4ol0/tyE3XIxBC0Ia3rRBkNH hKYYOO0vvZM6Y6cQa4XKEpsiuZ2gzbF2yciSswQNYlbVOmxo+zN4HRPqrnXGDlo0 RwBZLsxUuXhel88hYP6A2hfbEQO7nFnmjx8NGQtQueKK3aAA4qy8Tr2iuQHgm5hg SDWlJz7HBD7OIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=At1UzgpZmWa1xfWRtVpAcCjRhv2dx Er7nDeMaj4S77g=; b=Ki2tAsq4k99GjUYAiD80UeJawB5K2ZdfTJXQUgDTOboDl vYXvNL1+XBMO/jPte7v+Cv2TnTEv14LPguYzJkGdUdHWd7PlyG2EiCXYSomiagLN +RdZKWFt1hFUXO8GYqnItiYVukDXRiG4A/y3QPJ+H3I3HJZkd2hKDNJm9m0swA8f aQfbvSB85qGY6kEP2nPCEVIY6ejWPRIZlZIf0024O9X8x/ViCVAdRy4rsRTMKSsF zUgdktfKmQ5WKopkXUUpPOcPy7p3gzy03NTZWi0tHDxHncuHYB3A2QybO2L/TpT9 3KRNgyZ8QGRY4zv4Ze5r1atjei2PIlces33G/36pw== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (mp76f1fa50.ap.nuro.jp [118.241.250.80]) by mail.messagingengine.com (Postfix) with ESMTPA id D0A4CE4534; Tue, 26 Jun 2018 02:02:07 -0400 (EDT) Date: Tue, 26 Jun 2018 15:02:04 +0900 From: Michael Paquier To: Sergei Kornilov Cc: "lizenko79@gmail.com" , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #15252: "do not dump comments" in pg_restore help Message-ID: <20180626060204.GE31353@paquier.xyz> References: <152992021588.1268.16786093506650391435@wrigleys.postgresql.org> <6993521529922398@web45j.yandex.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="TeJTyD9hb8KJN2Jy" Content-Disposition: inline In-Reply-To: <6993521529922398@web45j.yandex.ru> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --TeJTyD9hb8KJN2Jy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 25, 2018 at 01:26:38PM +0300, Sergei Kornilov wrote: > Thank you! I recheck behavior too, option works correct and has only > wrong description. Simple patch attached.=20 This is clearly a copy-pasto from recent commit 1368e92, nice catch. > > > - Do not dump comments. > + Do not restore comments. > > > This is not consistent with the other --no-XXX switches, so I have reworded the documentation fix to be more consistent with the rest and pushed the patch. I can confirm as well after some manual testing that the feature behaves as documented. Thanks for the report and the patch! -- Michael --TeJTyD9hb8KJN2Jy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlsx1twACgkQnvQgOdby QH1/MRAAgc3+eyX2aVnm+aF4o0Bi9S/bQ8MSvgu/RGYd1aukGJysjnvMPC6fv1Yd /isy6FeZ9NHn0BxU7S7GRomY9q4j7f9EOu94Bt9owWlRLjlyliGWtDaJMIm3Z5Ax ysNGR3A4yXEkz+P6W2gNNHhnfcQAjAEEjcn/usiU9jMYCikSlgL0zwYfPY96St1j 6NPCt0H2aNOD0Agsf1Hsc9XUVvaombJcY0Pnfr6vioZeQENfcDt/te2puEsSx8AE 1rcabDozzLbD+7d4f3qlEndu/MgOiRIUYmuorGxqWxRyGCaekbkUqpYxrJHNGvh3 9g1DElKx8gW2eh6qMpCg25vOvpST121TDg/QB5k15l0M7z75spfW8t7wvu+Lpygo kyaYjrLVVEiT1o9rWcCMIq4oxQuOe5yKFkzeROYFIkOy/a017o+ENfD3OPwt4eTs mtqo+sRHsnhIrnWzvbwMycguk9BJq+z+Ptp+cvKVgBqjgwzAuK6BvExCFn0YFck+ 36Y/qj1nIc/syqPYQWGPABMMFqH6MMHHoRrVO+OOoy7y48yM3ONTH72TmVqY2Dgn PsoovEa1KRHQSp5pPQ39xKi95cevooF/57+4Ypqv+tO0TdwzJlhCN57t/kmpaX4u ADoJwJphb8qQzoH89WvGU0AwWv0ya8X/kQsAzFzEq1oQmKH67bU= =mCxk -----END PGP SIGNATURE----- --TeJTyD9hb8KJN2Jy--