Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fbZuM-0005jw-7H for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 23:12:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1fbZuK-0007ZB-QG for pgsql-hackers@arkaria.postgresql.org; Fri, 06 Jul 2018 23:12:56 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fbZuJ-0007Z4-0G for pgsql-hackers@lists.postgresql.org; Fri, 06 Jul 2018 23:12:56 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1fbZuF-0000HY-Fo for pgsql-hackers@lists.postgresql.org; Fri, 06 Jul 2018 23:12:53 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 936D320FE0; Fri, 6 Jul 2018 19:12:50 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 06 Jul 2018 19:12:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; bh=i/QZDkjQRyRs4+QokvNKLMFQI8fGslvrRWFv6bHrp68=; b=NKg6K2Li aVorAmU2c/W1yCUgOKhKdaic6sKGaXZdAhD9Ebdimf4oB9TBtcVnO5xDgEUH4Nse HzSfMyzPtZ0cED7Rhog4gnhdCeCq1NfYZUBdyBmafpptB1Mj8JeYg+8x6ESAIdyJ pe/3ey28hrGaredkWvobk0eTRr5ErLiJHaeFJatTerWfr51bYAHVLflrAncKte92 2t5HDb1odesth4myRvepaD+4GYNwZaPOqviFvHx1x7vWkDzB2xO9oZ3y40u2KTYc CKlDIU35NhBhPu/T9dX8ZBORflkkkbvrqLGXpoH6zy9mvxmy3z8rpavRi5eOZhnf 3CVGQIvI8oa1ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=i/QZDkjQRyRs4+QokvNKLMFQI8fGs lvrRWFv6bHrp68=; b=I7/IRxRGUrFgZ4zBsvjQZ873hbpZ6ltP+Ih2UN53/KwCz GHGKn27UrbRVg7EhTPwxn4Ot3Ex43aD3E2E3cTow20FWLCzeD0vY3iEZreqN2RuT +08Zc6x9nZ5VC4Rvi+CpO8Ly2Q1ITenClAC034LdPVPfo4NRu/zjj4KcmPqGCtwJ IOXY5iE9YW2MAtdAubrOgf5/67H2/AP5UawtFzIDDbbWE9XWrgVC4LxUg+i4k/aq ZKEYDIL8KOKD5SC9XgS4P3wIn2Kp57By5kZ2ldoyX3BKq8linVb41cGo9rU3+/wG datsHPRspr4AOJSeuCdL5uqYC9lsU30e/E7T7EUjw== X-ME-Proxy: X-ME-Sender: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 15C7DE4314; Fri, 6 Jul 2018 19:12:48 -0400 (EDT) Date: Sat, 7 Jul 2018 08:12:40 +0900 From: Michael Paquier To: Andrew Dunstan Cc: pgsql-hackers@lists.postgresql.org Subject: Re: BUG #14999: pg_rewind corrupts control file global/pg_control Message-ID: <20180706231240.GA1467@paquier.xyz> References: <20180104200633.17004.16377@wrigleys.postgresql.org> <20180619070956.GB31737@paquier.xyz> <153089194666.1384.16865372004585713975.pgcf@coridan.postgresql.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="UugvWAfsgieZRqgk" Content-Disposition: inline In-Reply-To: <153089194666.1384.16865372004585713975.pgcf@coridan.postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --UugvWAfsgieZRqgk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 06, 2018 at 03:45:46PM +0000, Andrew Dunstan wrote: > I agree that this problem should just be documented, and no further > fix done. The proposed commit message seems to be too long - I think > it should mainly just just refer to the mailing list discussion. Other > than that it seems fine.=20 >=20 > The new status of this patch is: Ready for Committer Thanks for the review, Andrew. Committed as suggested. -- Michael --UugvWAfsgieZRqgk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAls/92gACgkQnvQgOdby QH1wIg/9E7YdcXMDD016MOdqSRWHgS01rgkpRfdOG8NvkLuzZoFEPpRNNisNCElB Yk2aSVvHbSIOp7mNtWMYijM1txVG1HRNWlJu688Vbd6MPBc+RcQDxP29gIDkV1QK tr30AJmNqN/txQdHcmP2WB1s1t2zQ+42f3yPHg4JAvMt8A6SQ8znyu6/Nccp1oQ2 zKIVYSfHRcjOoUJmKgCE7tWiAqRRAif7cqI8fM2sldJLyHWiJlx7H/E6JH2tN/n6 avA49D8/2GWc7k6PBSCjRICF7dzd6saC/RcdmPnxOtls7YWQcwJyXf2E3CEDpkoI z+gj6bYQDMHTUVxBuXd3aQRrZLagrdJGk/HIpexu0csLC8QQrGB4VdRASj3T7LjO hjDLHkHKAiow9zDu9imBixPcxePbV85Zjs/gZ12Hg7A4+syosy1aA7aO0uORz619 gN5/uxiWZZr7DVIasKZfO3B9N1coej+MF/AOH4VOXUuUFG+6s9ypsllw2to48yiW pSw48Pj7pGUgFIVcFXRrba2G0EEiNLxTJ+D+5kosvD+GpJBy9A7omqusxwhvdBDY duC5DVguXaZ+L05MxPuDStSeaNFDShgjPsZD7EIfHVhcWJ4hiRWiU3xwlIUOqM1s /862ZMh0jOBAEo9YXxWJ122U3V4KvsLGnnYXijFCYwPVJIkc9OQ= =CM95 -----END PGP SIGNATURE----- --UugvWAfsgieZRqgk--