Date: Tue, 28 Aug 2018 18:34:41 -0700
From: Michael Paquier <michael@paquier.xyz>
To: "Bossart, Nathan" <bossartn@amazon.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	"andres@anarazel.de" <andres@anarazel.de>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	"robertmhaas@gmail.com" <robertmhaas@gmail.com>,
	"Schneider, Jeremy" <schnjere@amazon.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	"lalbin@scharp.org" <lalbin@scharp.org>
Subject: Re: BUG #15182: Canceling authentication due to timeout aka Denial
 of Service Attack
Message-ID: <20180829013441.GO29157@paquier.xyz>
References: <20180726204127.GA1754@paquier.xyz>
 <3D4F2733-92AE-4B74-8912-3C611B027721@amazon.com>
 <20180727023123.GE1754@paquier.xyz>
 <20180727.123702.77822416.horiguchi.kyotaro@lab.ntt.co.jp>
 <20180727041542.GH1754@paquier.xyz>
 <62728D88-85A0-4A9A-A4F8-67D96C1179E0@amazon.com>
 <20180811095003.GA2900@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="88pBQ1/6ie/nQzMF"
Content-Disposition: inline
In-Reply-To: <20180811095003.GA2900@paquier.xyz>
Precedence: bulk


--88pBQ1/6ie/nQzMF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hi all,

Here is a summary of what has happened since this thread has been
created.  Three problems reported on this thread have been solved and
resulted in different commits for early lock lookups:
- VACUUM FULL, patched on 12~:
https://www.postgresql.org/message-id/20180812222142.GA6097@paquier.xyz
Commit a556549: Improve VACUUM and ANALYZE by avoiding early lock queue
- TRUNCATE, patched on 12~:
https://www.postgresql.org/message-id/20180806165816.GA19883@paquier.xyz
Commit f841ceb: Improve TRUNCATE by avoiding early lock queue
- REINDEX, patched on 11~:
https://www.postgresql.org/message-id/20180805211059.GA2185@paquier.xyz
Commit 661dd23: Restrict access to reindex of shared catalogs for
non-privileged users

Please note that I have been very conservative with the different fixes
as v11 is getting very close to release.  The patch for REINDEX is a
behavior change which will not get further down anyway.  It would still
be nice to get a second lookup at the code and look if there are other
suspicious calls of relation_open or such which could allow
non-privileged users to pile up locks and cause more DOS problems.

Thanks,
--
Michael

--88pBQ1/6ie/nQzMF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluF+DEACgkQnvQgOdby
QH3qSxAAnkZoKCKVNUnnoSsQAPLMnZxK0ilBkfhbrN8hnCBpGMuLM5O6tvB3k2PV
AEi4mlmIbNMkFzSo0j4arbKpwrU73gjjIX9ULtvv6Q8GC3P7rt2tw4jYVDGuDZHR
egnifVgNAFFIwIG4YvP28jn/snCs9cGCsgQ8aPeqmLtTYhrGXLDJitei4lH9I9c3
0Zw33K6iYqt4oBx1Sn3szJymLmNXinPgri0/fx0xo2WdtMIHg0pBv2AJpxCclo2k
L/jiCwhmLIgeMYiI9HiFCizy1cio9ooBco7O6Elcw7+O/eBvkhKzLT268bFoqPP5
Sr2Pto8E9yzY6MQdDX8hqU3RiFYU7sYxuqtOzcgAwzRZiaNK22NjN/yAD/WQaBCp
gfLIhL2o++DZDFu7OabUUWrYytJQrNdA16QehDCgAsCnVlQ8j8e6FguKQa29cRHg
lEiDjM4NSiZtNtOkbhS3oPL/F4JX3oDIeUOxxT6keFW5BVTdNEXMyDeGkQN34/iK
2yEzky/Lal9XvYwzM4T2vBBkoZvfb7zq3EKtLfHf7AJKwXh1SLNPfJow39+/JApq
l/rKa4hP7rzCEBculMd+BWOBLKxPg/OjJ4ZU/X82qc+EG6/xj+RkJjDzCjp0sTr/
zw9B6GxuZn4wa1Af7FNRf8UYrLC/fH2zQr+s6TCwq+RGEG6gzxQ=
=GGlT
-----END PGP SIGNATURE-----

--88pBQ1/6ie/nQzMF--