Date: Wed, 29 Aug 2018 13:54:36 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Alexander Kukushkin <cyberdemn@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>,
	Dmitry Dolgov <9erthalion6@gmail.com>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15346: Replica fails to start after the crash
Message-ID: <20180829205436.GE5903@paquier.xyz>
References: 
 <CA+q6zcVjv1Lp-3=prBbpq2CbBioK91SHarfw3F8FHuUN4EwcUA@mail.gmail.com>
 <20180822175034.lnvwk5js32k6mjyz@alvherre.pgsql>
 <20180823041420.GA1158@paquier.xyz>
 <CAFh8B==4gpwor6ODercru0iifqwd0nQrdRvXzmorWkMRQa4q=g@mail.gmail.com>
 <CAFh8B=nHdsX83hTZMqGqbht39ud+DRQOv4_Te+xu3DuPssQbZA@mail.gmail.com>
 <CAFh8B=mYGP1J8ueHKU40Dr4bNBUPJj1rTbZ6Wpg4gR30uCRunA@mail.gmail.com>
 <20180829061723.GA5903@paquier.xyz>
 <CAFh8B=kuFyBsth-1wuPqncnTiCa7reKzCz=RzO1X-Y78U74F5g@mail.gmail.com>
 <20180829121051.GC5903@paquier.xyz>
 <CAFh8B==_6cY1f7rF4oxK+wjpWKaYzs96Q6Tn5=4QRWJiVnjmDg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Yb+qhiCg54lqZFXW"
Content-Disposition: inline
In-Reply-To: 
 <CAFh8B==_6cY1f7rF4oxK+wjpWKaYzs96Q6Tn5=4QRWJiVnjmDg@mail.gmail.com>
Precedence: bulk


--Yb+qhiCg54lqZFXW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Aug 29, 2018 at 03:05:25PM +0200, Alexander Kukushkin wrote:
> BTW, I am thinking that we should return InvalidTransactionId from the
> btree_xlog_delete_get_latestRemovedXid if the index page we read from
> disk is newer then xlog record we are currently processing. Please see
> the patch attached.

This is not a solution in my opinion, as you could invalidate activities
of backends connected to the database when the incorrect consistent
point allows connections to come in too early.

What happens if you replay with hot_standby = on up to the latest point,
without any concurrent connections, then issue a checkpoint on the
standby once you got to a point newer than the complain, and finally
restart the standby with the bgworker?

Another idea I have would be to make the standby promote, issue a
checkpoint on it, and then use pg_rewind as a trick to update the
control file to a point newer than the inconsistency.  As PG < 9.6.10
could make the minimum recovery point go backwards, applying the upgrade
after the consistent point got to an incorrect state would trigger the
failure.
--
Michael

--Yb+qhiCg54lqZFXW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluHCAwACgkQnvQgOdby
QH20hg/9GpQK0+mnBVPOh2qpJbD7gSSUPueBgvArZBteN72yTYspalPOcsUuhm2h
0/jN3ivrs+wFO7RQxdsBXOsR1xWS/hxcGYECsUrMHTRAJPmcW5D+5P95B3fq0GsV
WGSiR54v7gdlTN2YJ7x07BVEGV3zuL0FqKqzo8+dKECpKFQ/fmXKBsgMnERTRS0W
FuRnT2tptJ1h2Kn5yOkIimisiKTbtwd/F1hnmvm977bMPdn2WDoLQSSSspcxSMSE
LKJlKfnReTfpeQlFZNuf0ZZZAx8T3bgzAapgjtUDIon2yHK4a27d/74X3T3LulLM
KTV4RNR1t5tzsdlwvZ1huNFcTpQLmUKog3fmQwyEo4fYQeyYETJsLA7i+uEz+6Ce
lkhgwhooqvYKJDQMNA36OGNy3GHkd9A9A+LS2A1vmMPNveRotje/DIMyJCBXoscX
LgblsQ1gV4+Wic+9HQtYhGdg82Bg1uDeCSxHdDm9dZJ5J/ygPZpe26kC2l4ItKay
5lrs3ZX3I9/Q8xkGWjf5Zs5x6Red3mCUUgd3Ll9J1qZbt7UcMDMr9xwTYOBnPt5A
FCs1/KA2vZHYUaECWJL18On6x0T+hkhtOAg90ZXK2z6B0263oJFM+q4g2QS6gRUD
XbesxF5yxBnJJoWSTXdGbSDw3NDc1l1GRZ/dSIqIvYsbiigBKxc=
=+TKT
-----END PGP SIGNATURE-----

--Yb+qhiCg54lqZFXW--