Date: Fri, 7 Sep 2018 11:15:22 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Jeremy Evans <code@jeremyevans.net>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Message-ID: <20180907181522.GB32058@paquier.xyz>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
 <20180906215836.GP2726@paquier.xyz>
 <20180906222843.GF17425@jeremyevans.local>
 <20180907165103.GH17425@jeremyevans.local>
 <20180907175518.GI17425@jeremyevans.local>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GID0FwUMdk1T2AWN"
Content-Disposition: inline
In-Reply-To: <20180907175518.GI17425@jeremyevans.local>
Precedence: bulk


--GID0FwUMdk1T2AWN
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Sep 07, 2018 at 10:55:18AM -0700, Jeremy Evans wrote:
> Here's the backtrace:
>=20
> #5  0x000017c20a6b8b00 in pg_fe_scram_free (opaq=3D0x17c223712000) at fe-=
auth-scram.c:127
> #6  0x000017c20a6b9d20 in pqDropConnection (conn=3D0x17c1dac61800, flushI=
nput=3D1 '\001') at fe-connect.c:479
> #7  0x000017c20a6bf95e in closePGconn (conn=3D0x17c1dac61800) at fe-conne=
ct.c:3710
>
> Hopefully this helps.  If you need more information, please let me know.

Thanks.  This fails when freeing the password field in fe_scram_state.
I have a question: does your password use non-ASCII characters which
could make SASLprep to be run on the password string?  The result string
=66rom pg_saslprep allocates a new string for any results returned by
reading the code, I am wondering if we could be missing something..
--
Michael

--GID0FwUMdk1T2AWN
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluSwDoACgkQnvQgOdby
QH07ig//VTb69kboAyB1CF6G4I3KEXNKQWvAYMsbwHFvGcLPiJUa4q2+VGdr6RYZ
vc4k6t34eNL0EkSVV6m3QlqHdwtl//9gSuNdHvd5LFTBpnJJKPiIWM5X0PJq8kNp
XZu1hp7myaEXbxfvxgBLDnKoOS8jwQeXFoMYgUBAP9KsKmh6BngqyzjGbFVl8HoU
GVWbRGrMlDx/qCu5F4KtBs16VUMmCRbTt6c0zzZw04mbT7NXfDGZaWZXwFFYvwHD
IvuZJUFPvFAvx9V3QChaHW2OnXPJpzQo2eAJEtJYvVWRYED9DnDo82HSi+3JnN/8
sY5cw+O3y+vCrOOEBTjbTLIHg0KiM8MXIFs3wiPMnBRlOXIv14OTLyaqULuWA0kV
8NdMpvvL9ixi0e+SrrUD5aQrG2vuVGkomgdubfb+6MBWEQ22PYTgHvdXIKYlL73P
2gEn/0BWUv01PQ4lP7KkwSO5FiuxkteOwyJ9gvMa0jYJ6O4xc7TPq/l+F8U47EZ8
rqpTXmfT0spW04U5uMy74ET39tDGW/4CDRfLP0xtxDqkU3a/UfjIgnD3KYoBcTFT
F5zdEHHaO3Kj6zpDyyaNcWQIN15nJ9r7Y/vJR6t6vhdsuOk9cdTpsy68NeslVFq2
qszHwkiAcGt4ZVKzwV7Xhy+PB8dLug7xN7/2GlU5Xa6Xz49o2I0=
=7aVk
-----END PGP SIGNATURE-----

--GID0FwUMdk1T2AWN--