Date: Fri, 7 Sep 2018 13:44:03 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeremy Evans <code@jeremyevans.net>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Message-ID: <20180907204403.GC32058@paquier.xyz>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
 <20180906215836.GP2726@paquier.xyz>
 <20180906222843.GF17425@jeremyevans.local>
 <20180907165103.GH17425@jeremyevans.local>
 <20180907175518.GI17425@jeremyevans.local>
 <20180907181522.GB32058@paquier.xyz>
 <20016.1536351535@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+nBD6E3TurpgldQp"
Content-Disposition: inline
In-Reply-To: <20016.1536351535@sss.pgh.pa.us>
Precedence: bulk


--+nBD6E3TurpgldQp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Sep 07, 2018 at 04:18:55PM -0400, Tom Lane wrote:
> I had been studying that when the report first arrived.  I'm not really
> happy with the coding in pg_saslprep(): it leaves garbage in its output
> parameter in some code paths, and I think it leaks memory in others.

Agreed.  Do you want to give it a go?  I can see some of those code
paths?  Likely you spotted more.

> But I couldn't see a path that would lead to the observed failure.

Agreed.
--
Michael

--+nBD6E3TurpgldQp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluS4xMACgkQnvQgOdby
QH0I4Q/9FOEA+qxpWtvTbbSuuW+tNEqEfY9kiwxTLpptQxqp3h3Iu0LXQdExwBgi
MFWuhNcahKi32o2E6JCDtk0WF2UsMKrJ6ldH583e/cleLjHZmDFX2/Bm58RUC+dh
CbjmFKxVx3eOKlJc4SMqQebOJiFhqWPbIpmAlHEf9SOZcqJk2XPKJZWQMZvnNN+A
r5oZY5u2hS8TMMEkq1jK+sqDF0AsBn/KxZtz+Nz6N/f9SLEU9OMo/ltCfnlxYFCH
dLJUnTBqmh8fQcwer6jjFADq+95VtGrCg68U/5/OyEN5mGp7fMNTLVS2HfPwf3wf
D8uuAiHUbNUyNKC28gcNHbT9TlnUNHj8EgQ7vCADPYUUT41bLx3EBKvwpSUJjHPi
B2H4zJY/Xn52qe11VVmH2ORvFoJawWU/JY+jmI8ZTdokXifWK26gmBmOfz02IWMr
zxQXdyWC+ikA5teW00yC23tujVIPDKTDouEnla9aj0Bw5tPImY2mMm5/JI0MOuJX
kUoRTHpro1v8EFvMG0Pa0CcVzwDIQuB4JzipmB3fxS9DSXLmrqeBelkv6QOpdMVc
5GDJCwX8CM0QWdojcAy7d68R+4Jop4idMBNM0SYvbYDxKBJYxTHqSO8qGPh0RguZ
pD8n4Drd6OOwlMrXbXnQ73aHYY3z5fYEsSXwtOoPs3vqpkoRE4A=
=wl1w
-----END PGP SIGNATURE-----

--+nBD6E3TurpgldQp--