Date: Sat, 8 Sep 2018 12:31:58 -0700
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeremy Evans <code@jeremyevans.net>, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15367: Crash in pg_fe_scram_free when using foreign tables
Message-ID: <20180908193158.GH32058@paquier.xyz>
References: <153626613985.23143.4743626885618266803@wrigleys.postgresql.org>
 <20180906215836.GP2726@paquier.xyz>
 <20180906222843.GF17425@jeremyevans.local>
 <20180907165103.GH17425@jeremyevans.local>
 <20180907175518.GI17425@jeremyevans.local>
 <20180907181522.GB32058@paquier.xyz>
 <20016.1536351535@sss.pgh.pa.us>
 <20180907204403.GC32058@paquier.xyz>
 <16558.1536407783@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="SUk9VBj82R8Xhb8H"
Content-Disposition: inline
In-Reply-To: <16558.1536407783@sss.pgh.pa.us>
Precedence: bulk


--SUk9VBj82R8Xhb8H
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sat, Sep 08, 2018 at 07:56:23AM -0400, Tom Lane wrote:
> Looking closer, there are no leaks, though I think we could use a comment
> about that.  And it still makes me itch that pg_saslprep (mostly) doesn't
> worry about clearing *output on failure while only three of its four
> callers bother to initialize their variables to null.  That's a recipe
> for future bugs.  So I propose the attached cleanup.

Okay, that looks acceptable to me.  Thanks for looking at that.
--
Michael

--SUk9VBj82R8Xhb8H
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAluUI64ACgkQnvQgOdby
QH2Yog//SFxPyI8WpOPOxhOC29M6CcdpHWWUOnCBTkE/BksaQ7FMonP1OiLbYsHe
W5eIp3twJvS7aG92WoaOFzXdYJTuSRgkU2uH36DQlGoYD3s5FDwe+T5zUC+aKUuQ
3wTG6j/ZBjcnQMdOQs9Q/oI2lvpSd1IU8siIU8PGpHNeXf4TioKI13TlCOc+dwNr
OO9r2cUeAkThbVIO88zjpY38uUw2/lY60aQ5TUy1tdbPMdSzX60GhtXK2o7j2/JZ
FATMrb98vDpAyJmEh7zbPy36Ku9G2I0fDJEROo/L5hAy4bALBoBmkbY+hCVHzIMQ
Bqt5rvfSvaAsJGwchcN9nyBRR9ZpUJp8hhJk+Pw8ciBPBYloPyn19DyHpsnLrK1W
7OT2E6W2CixHhMadWnRJg1aG1Xpr8+cDeY3neul35OR4PH70in89ZWqBhww90OpT
xxUSfKq6qZVBdXhZJWEM/v99Ek/w4EA0GS+s3IH9UYlzGiqQCpW+YRomE3PVcy4I
ycYLjwdImuwE5ILrRDVX2dAw+nRn8J8eg+ogm9de0PAusAiXRELAQch3pk7iYD+j
e3V7CwlQgQ3b4YsAudCuJsOzKQ0csKov8/4/eQw9YbxP0ksWIdmw/2qqBcqlSqzw
E6Pc8fBu9aD4YRnW/q8z1WVFT4LipV/bL2vmj/Wi6jGkyOqnCJI=
=g4lV
-----END PGP SIGNATURE-----

--SUk9VBj82R8Xhb8H--