Date: Wed, 26 Sep 2018 12:52:05 +0900
From: Michael Paquier <michael@paquier.xyz>
To: harukat@sraoss.co.jp, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15402: Hot standby server with archive_mode=on keeps
 initial WAL segments
Message-ID: <20180926035205.GJ1659@paquier.xyz>
References: <15402-a453c90ed4cf88b2@postgresql.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iSeZnk6FyAS3EJ1y"
Content-Disposition: inline
In-Reply-To: <15402-a453c90ed4cf88b2@postgresql.org>
Precedence: bulk


--iSeZnk6FyAS3EJ1y
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 26, 2018 at 03:26:50AM +0000, PG Bug reporting form wrote:
> A hot standby server with =E2=80=9Carchive_mode =3D on=E2=80=9D keeps ini=
tial WAL segment
> files that copied by pg_basebackup. It shows the following status.
> 000000010000000000000042 will be kept forever in this case.

How did you find yourself in this situation?  Did you take a base backup
=66rom a primary which had .ready files in it, and those got copied to the
standby's data folder?  We may want to study the possibility of
filtering things when taking a base backup instead.

> Though I understand renaming the .ready to .done manually can clean it,
> I would like to fix the server code like the following patch.
> I'd appreciate if you would consider that.

Your patch looks incorrect to me to begin with...  What if archive_mode
is switched from "on" to "always" back-and-forth and there some of the
past segments which should be archived are not?
--
Michael

--iSeZnk6FyAS3EJ1y
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlurAmUACgkQnvQgOdby
QH0iHg/+IzedtV9T3Tew+kot8LC0F0CGHbCKqy2nWaXwRm66Fwz9hu8U3cLIqrYh
Z0V347Oz/H5AAZTYiFQcv0Y95Rfsvnir+JaFZVlsxFAGn/SJwX4+9xJcEI2RPYpS
qHNNvl9VEdA6ZIAQsZEPHk0HM+ZDZmfbHsiZrAlskAYKH4TzQxmyBaLwvEsgTID9
uJzMEN8lh++V+4lQTPtsSUrRsmecvpqDS3jyH4htI6DQ81yotYf3JIzK1o5wy8G5
A0krTqNwUUpK+nQa48wBn2pl7I5IBXa1bSn+ECx7OCrrRNDLeSYlv57KfLtZZu6L
7NVF+Rk2U67aelfvueWsc3na1s4Nf5BLAloiwcKKvHjOPu8Osa28G6dvfElqpLsX
kHN3ldmbRj/6NeL/nhYFGLcLWcI9Rid9oNegZx+GMUl0OK8KUgKIkcIIMOwK56JW
OAsMdtjZoqAn30LLitieYc90EIgSjon8XwzC4nLwCL3nuSFg/2DD7U3FyJ3ewaMu
D9kaawdv0O/GylSxxslkLsgD9H03fUKXDl61o+ggkbE20L96vLzDj/ShM30sIoEb
LSz8OwKSCTyY3NxWLlb4Gmk+Ke8n3eI/TiFOS/lIkMThORRk8zOZcwwHP3wJT2BK
LcpfNw9DIWzcAbG/OTU5X98gHgwfQ8u37dBoxsKExu05YoZZLjA=
=quZf
-----END PGP SIGNATURE-----

--iSeZnk6FyAS3EJ1y--