Date: Mon, 29 Oct 2018 15:57:14 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, skaurus@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15437: Segfault during insert into declarative partitioned
 table with a trigger creating partition
Message-ID: <20181029065714.GI14242@paquier.xyz>
References: <15437-3fe01ee66bd1bae1@postgresql.org>
 <e8079b1f-3e41-d1dc-1575-ff3cce7d76ac@lab.ntt.co.jp>
 <8213.1539917571@sss.pgh.pa.us>
 <ddc70376-9ddb-8637-eb69-aa7ae6f13378@lab.ntt.co.jp>
 <20181029033117.GE14242@paquier.xyz>
 <39fc3c42-d34e-794b-184e-4ff2481245e3@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Op27XXJsWz80g3oF"
Content-Disposition: inline
In-Reply-To: <39fc3c42-d34e-794b-184e-4ff2481245e3@lab.ntt.co.jp>
Precedence: bulk


--Op27XXJsWz80g3oF
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Oct 29, 2018 at 02:28:53PM +0900, Amit Langote wrote:
> On 2018/10/29 12:31, Michael Paquier wrote:
>> In the case of a partition, the execution state relies on the data
>> inserted, so the restriction sounds fine to me.  If one tries to attach
>> a partition after creating a table you actually get an error:
>> ERROR:  55006: cannot ALTER TABLE "check_not_in_use" because it is being
>> used by active queries in this session
>> CONTEXT:  SQL statement "alter table check_not_in_use attach partition
>> check_not_in_use1 for values IN (1);"
>=20
> Yeah, I forgot to include this example in my previous emails.

We may want to add a new test for this one in the same spirit as what
has been sent in the previous patch.

>> Other callers of CheckTableNotInUse() use command tags, which is
>> inconsistent here, still I cannot think of anything better than
>> CREATE TABLE "%s" PARTITION OF
>> or:
>> CREATE TABLE .. PARTITION OF
>=20
> Maybe the latter is fine, because we want to highlight the parent table's
> name, not partition's.

Fine by me.
--
Michael

--Op27XXJsWz80g3oF
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlvWr0oACgkQnvQgOdby
QH0maRAAgLmp8a3UQAXYTAFt2M474buS1MVNBydwrhEC153WKADefPdpYv1nJ2VP
O7+tLLB8Mdke9LkYLiBhuAT0awlFKaiyiH4tKYBrO7FEuxNqb/E5NOH8YAbX9i7e
IZlTRpCaPg+b1sZuwQ/ZxRR4f6ElKVmhyAjvzepKkNNaxwOfEYKfsnTis455yk70
AZIofn1aAh8djjGHS/cUkpbLg90OSwI2GWVeUF9FcIwt5yvuMAXcN+M0bW+x6AkG
wHsXO7ZGVFV2NeW8LWfWJ0Re4O0z4lalOLEpHOuPMOTDBvmKJe2umE79AfGd6xzC
HY6i907TMAN0BncTTT3mHl4tFgk+z+pMWtqrP35EbLfqtbpFqS61fPgNncrpWfZD
avekWLJU4zh2HRHnlQEStbhVkemDKR8uSLyc4AHZ36Bi/WmD2mwceCChwTpMQqAm
dbDv8lSw5Q+L+oLrDsTBXSHE+4AND0oU4K0JxkeT26It27To5Fxdyjyf0nQsZ5n7
x3sBul+IMpXj2lx+kTlG890iwVff23SaozV/3+yKSXt/img3FKuWaSkJsCzxWaIj
5rhpVw4hNOC+R/GSAK+4gP7hLlifDw6fqQBsfidkr2f1Hn0i4rTUXkgALyLhWtU8
LRG8QiDr0rQN61T0j7QnokxQGb0BCBD+3eBqKz2wDhopkEgzaBM=
=RZRW
-----END PGP SIGNATURE-----

--Op27XXJsWz80g3oF--