Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIMqv-00087M-RI for pgsql-bugs@arkaria.postgresql.org; Thu, 01 Nov 2018 23:58:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gIMqt-0004ee-4y for pgsql-bugs@arkaria.postgresql.org; Thu, 01 Nov 2018 23:58:15 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIMqs-0004eX-5Q for pgsql-bugs@lists.postgresql.org; Thu, 01 Nov 2018 23:58:14 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1gIMqp-0007Aa-67 for pgsql-bugs@lists.postgresql.org; Thu, 01 Nov 2018 23:58:13 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id B2E392213F; Thu, 1 Nov 2018 19:58:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 01 Nov 2018 19:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=p/Dxfv56nO1LnoJR1e7d0VCWopM MWhGcvwABgOTQw30=; b=A2klmf4v4QF2efukylcUOqyv1if3U6GsAB9uCNczKbX FHRqdptrHx4B1fLKsebtjhSiEwIC4qmOD2NJBNNh0dmz6jhVjv8vSKVbPUzfgWlU 9Ktlpx+5isYUuUZlcCBiyHsb3uutOUW0N8cdlfg+ox26U832m1vs5qTvWwWbzGnJ JXl93FTnbBrnldRbGmnn3TdZb0eEKp2ILc9aJNFgIJ+ng38PPdaEDafpjNBia0Sy 7JVzLcbtmR4X6YxPDH3pML7rmp892PcrtjKF6F1CjE+Ui+N0p1qMxwV0lJB2P+Yc V1kAEdEoeluyK7up4WTrIvC4P6kDd1Ab/V7jefAz3LQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=p/Dxfv 56nO1LnoJR1e7d0VCWopMMWhGcvwABgOTQw30=; b=uxvnJqG4teZF/jhrophjGN 2rOSBizmKVC6s7MxbzNUH3jNpH9s5bKQzmfPSMkbf8YZvtkUrk2wymO9bLxSDOQe WkW2YtMLZ5fzGOxGI5ukdxk8vtQpH83OmB4oOE874R/wCpouUqbqo5kAykSP1gaH V7E+cfBVefgMJtqGolVlErXKaiP02ZRhcdQ9NPHbLjFGtcN2lgxRzYnXMB2aHa9D o8/Fh6cH4FLyBr2FNDqQM1D5SuUb4sA7SBQAElVAA0QSfo9cApnmjQkfcWcbkQV8 N03dy3yZZZloGvmjXRDfYgGtqoWT1l0CG+3ZOdlie2wI/sqpfQjaZ5f0xghJ48mQ == X-ME-Sender: X-ME-Proxy: Received: from paquier.xyz (mp76f1fb94.ap.nuro.jp [118.241.251.148]) by mail.messagingengine.com (Postfix) with ESMTPA id 7ABC9E4119; Thu, 1 Nov 2018 19:58:07 -0400 (EDT) Date: Fri, 2 Nov 2018 08:58:04 +0900 From: Michael Paquier To: Amit Langote Cc: Tom Lane , skaurus@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #15437: Segfault during insert into declarative partitioned table with a trigger creating partition Message-ID: <20181101235804.GJ1727@paquier.xyz> References: <15437-3fe01ee66bd1bae1@postgresql.org> <8213.1539917571@sss.pgh.pa.us> <20181029033117.GE14242@paquier.xyz> <39fc3c42-d34e-794b-184e-4ff2481245e3@lab.ntt.co.jp> <20181029065714.GI14242@paquier.xyz> <751f72ac-e5d5-abef-98d8-ed1ef8c9d6cc@lab.ntt.co.jp> <20181030041119.GA23393@paquier.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rnP2AJ7yb1j09OW/" Content-Disposition: inline In-Reply-To: <20181030041119.GA23393@paquier.xyz> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --rnP2AJ7yb1j09OW/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 30, 2018 at 01:11:19PM +0900, Michael Paquier wrote: > That seems to be what we are looking for. Let's wait a couple of days > and see if anybody else has any input to offer on the matter. I also > would like to think about it again once. And so I did. s/paritioned/partitioned/ in the new comment of tablecmds.c. The tests could be designed better. We had better not use the same object names across multiple tests. If for a reason or another both test suites are moved to the same series when running in parallel, this can lead to race conditions which would be annoying to debug. Test cases are not much portable as they rely on default partitions and this bug happens down to v10, where we need to back-patch. It can be changed so as we use FOR VALUES (1) or such in the DDL part of the function. Those are easy enough to fix and improve, and the patch looks good to me. Any objections to commit and back-patch before the next point release? -- Michael --rnP2AJ7yb1j09OW/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlvbkwwACgkQnvQgOdby QH0rRw//RxYQ0mDPfbjgO9CbM8YgekEeoC9C1GhAWNhPnmZlGEQTv9CZKeIs1u1N Qu67XYiCOptgraZP84g/bTVt20uFTbu0NH7/gGjGNf552kJxlI8Cm/Taad6Ljtjv cBnfTIKHHLPCdh4tpltF242B2/wLd9UDv3kUcgUjdXqCmtMZ5itpMHvaXkd+XD15 u4NBRAhBGgPVD7CiUsiYJcTkrAHkfqVzMcTxOjukcPlzeu6UYqTKtzSEJXYNrngv dzxCyHq8xsjNBdndFfQ4lHui9h43FGJsuhi7RrkjWXPTq1NRjbC68kwQFXTl9uNj ggUf4f6Rkd+wEV8A+eHbuketfPqevf3esX4tlYYW44d6FaqNqI4rbxEVUZ+DjTik M8W7MYWc1n1cOOqTODfEWspNwrSJ2XXhMJFAHboGt89sY0PAvI8J2BC3PTS5fI5H EHVW+LOTbBcVuCPWsRflHMiVVpK7C9a1T/uzUCE92g6F8EciOqIQ/jolP7qds77w XHrNbX/BR5LsnKcZ6nIb+L8+/cqtm3h/d+w3u2LaCZepS7PhzK0/aozOb7yBV/TH Ka9be/m9kvI5pTfL4LJ36rGcmcVg/wMGlgr3vOCJXt3uS0U17lUJI0iVqGzkvcuS isZKXc3yVaNMKvfx6RrpRGnewJV1ohCNlbPMPdL6yzM+6jwf8h0= =ZwJY -----END PGP SIGNATURE----- --rnP2AJ7yb1j09OW/--