Date: Tue, 18 Dec 2018 14:04:19 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Luis Carril <luis.carril@swarm64.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>,
	PG Bug reporting form <noreply@postgresql.org>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a
 transaction
Message-ID: <20181218050419.GJ1532@paquier.xyz>
References: <15552-c64aa14c5c22f63c@postgresql.org>
 <8e82d10d-cc16-eed4-7634-3654f59d8053@lab.ntt.co.jp>
 <LEJPR01MB00109D0BECB8A961074A7CAFE7BC0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
 <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="FCKy2vjPBX+S/5dE"
Content-Disposition: inline
In-Reply-To: <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp>
Precedence: bulk


--FCKy2vjPBX+S/5dE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 18, 2018 at 12:24:54PM +0900, Amit Langote wrote:
> I noticed that too.  As you say, it is not possible to exercise a test we
> might add for this with `make check`, because it runs with a fixed value
> of wal_level (=3D replica).  But it is possible with `make installcheck` =
on
> a cluster that's running with wal_level =3D minimal.  Maybe, something li=
ke
> this:
>
> [...]
>=20
> From the above output, your patch will make "ERROR: could not open file
> xxx" go away.

Last time we discussed about adding a test case in this area, we came up
with a TAP test, so this could apply here as well:
https://www.postgresql.org/message-id/f20181114.124736.206988673.horiguchi.=
kyotaro@lab.ntt.co.jp

What scares me a lot about complicating this code is that we are not
seeing the end of it with this so-said optimization in removing the
relfilenode like that...  There are other fancy cases where the failure
can happen (please see patch 0001).
--
Michael

--FCKy2vjPBX+S/5dE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwYf9MACgkQnvQgOdby
QH05Lw/9GBaH5fUllAJgYDSltHRLKCYSDxiGaZk0dz1q2eZ7dHELeB5ZvMRCnarw
EoT6njDGYVQTNGHaXiCxQzIxNZEY1ZUYW51VSKKXiAyz5PQTfN+g3fgH1KKiSREg
UhUs8oahSh4l/F9nJmflUpNreo02Ict6Bdw42joA+2wndmybKh0GZxfNuToWEKjP
5ETyJCb3RQcmzinQtAHVDvxYoXxcve1LI4e5ONHIP6RVCr84Vhwi1yBPsg5QZKY3
GvWGt84YLZM15KYiCAXMHqR0Zgdorb+dQz7Ewqu0vXWzLdMjKCnN6GCFYAhMUPqw
7K1u/CODRabdOcvagjBmxMAfRX5az41W7Fn9l8GURBx/WmSTgHojurDqLHbs0bXV
XoItuJcJ35MRD3bWG/up6XLcWaRtaONeE1/KiEo7cZ1I+/4pehdMeJ5s0dv+8I3h
hUa4Z5RacuP5FVLZss3idgDm8M5RqoWU2SMwFrjmbbLesiz5WDduWEYvzKroA37n
IzCcumY5diTL25kdHYibksxhv2HE6ecaN6brdea8Np7ZwzHyF47XSSs0G0ckq6TZ
c/71stLfWfekRA6yKd3vEqVWg/SgFdJDoGKrhE8xzocLTEWudLXGQOiLs4JNGeS5
gG2N82SJSBqd3lRheKEYYJMr7ml1013l7MzNby55zxkJMxyxQYY=
=G+xL
-----END PGP SIGNATURE-----

--FCKy2vjPBX+S/5dE--