Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZ8wT-0006rg-As for pgsql-bugs@arkaria.postgresql.org; Tue, 18 Dec 2018 06:33:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZ8wR-0000MD-VM for pgsql-bugs@arkaria.postgresql.org; Tue, 18 Dec 2018 06:33:19 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZ8wR-0000M6-Ox for pgsql-bugs@lists.postgresql.org; Tue, 18 Dec 2018 06:33:19 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZ8wO-0006cT-Nv for pgsql-bugs@lists.postgresql.org; Tue, 18 Dec 2018 06:33:19 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E9A7921FDA; Tue, 18 Dec 2018 01:33:14 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 18 Dec 2018 01:33:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=ak0oJo2Tv6SzZNpOSYZHM+sUePa lJTeK8ZeTzgoWm/0=; b=Dnb2LWxYih0BPt/2WlUWUaj1pz5HygaYOqUi+cqWxAl 1rliiUtEj8YIMJm0agglijIkiboXTagN+w41V9ZE4nX7v0+V1B2duzF9ezYg08RL uBbbP7lXmp87c+7q7LKhrfu262sei5+Cy34RiMNNvvkS8JxJhe2SX687MWjsSMAC /HRShB0jVBxqidXmirHWjlzCDk4B3Lx7+u9nrwnPsS53RW31pAR9EszfIPoi1gYg eEZuMADifzAQRZKLTKU9dcQPmlZMFkbXoYgiAAux6iZteEWvFe8SwqqIf4uxHWbc a+DEbw+jV+QGo9ZNlN3o0qe1PmxxXXwaqAFB5m92WUg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ak0oJo 2Tv6SzZNpOSYZHM+sUePalJTeK8ZeTzgoWm/0=; b=oWsk/0ROiTKtyK9ikfgSE5 VPjbv7dKkyOXSimJ0xE3dzrxkJ1NVw7Rp/ghYBiVrqsBb+AkXbSKM2Pod8qM18f5 9Xvj2lKAiliEwCthcEmE0kUl8RnwpKp3e8ERmwUy7bOGpCqB8C+zhtL9OgH+jIUs qQK1M0C4SvDB0aor3EUEPtNocgmZvu8CtNIsIjb34DQ55wco3dvrY+wU772zoxc/ cAo4EAO8COQ3K3AgRPPpR8lFqdMYY5dX5LFJnHCoNczL4uLPGFaHC7J6N0LW3lvt 3uDPsjdJFnmeFx0OOEVyWWYtjD4JbcRw+/11MOD5rEqpvAckpb6TEPWZcQEMo5hg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeigedgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdefhe dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucfkphepiedurddvudehrddu feejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquh hivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id ED35D1026D; Tue, 18 Dec 2018 01:33:11 -0500 (EST) Date: Tue, 18 Dec 2018 15:33:04 +0900 From: Michael Paquier To: Tom Lane Cc: Thomas Munro , hugh@whtc.ca, daniel@manitou-mail.org, PostgreSQL mailing lists Subject: Re: BUG #15548: Unaccent does not remove combining diacritical characters Message-ID: <20181218063304.GN1532@paquier.xyz> References: <29419.1544908811@sss.pgh.pa.us> <31564.1545078667@sss.pgh.pa.us> <20181218045708.GI1532@paquier.xyz> <8506.1545111362@sss.pgh.pa.us> <20181218060735.GL1532@paquier.xyz> <11345.1545114237@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="oIlomvtVtXAVxSKT" Content-Disposition: inline In-Reply-To: <11345.1545114237@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --oIlomvtVtXAVxSKT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Dec 18, 2018 at 01:23:57AM -0500, Tom Lane wrote: > Maybe I'm misremembering, but I thought that discussion was about the > code files. I am still mistrustful of non-ASCII in our code files. Yes, that was in generate_unaccent_rules.py: https://www.postgresql.org/message-id/25859.1535076450@sss.pgh.pa.us > But for data and test files, we've been accepting UTF8 ever since the > text-search-in-core stuff landed. Heck, unaccent.rules itself is UTF8. Okay, fine by me. -- Michael --oIlomvtVtXAVxSKT Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwYlJ8ACgkQnvQgOdby QH2RDQ/+O+KtyBWPtTlFEULZ7rv7Dy6+2e4VTgXVzTK9d9Fnv8IFXwfT1pTXDtA7 xmImAKudEFDsb0TEBC7A3CCxlFQMOCAFXRtnGVwSNNAx8FN3mKKo6VKQhkSLgr1d Migk3yI/v3wDhR7UBB5uwRBiA4HxsrmfiRyMlBNCqoFA9JQR1hoT/Ydr4KWf6u65 pMOevxCHfojUOFoFbz6WPwF1N58LrpZYJM+lw/4ddwk3mSwK14X56rAejehhzQDL gK8g5Gs9uRRsloEVGNkzm2UlyOCPo37ZsL+cqNtHLTzBJT4wxVAWWH0m9Qf1tEWh iPphYiuaNAzjVQZOJKgChSUJXtu/1orsND/Uv4Sj0QwatH9PEWanfE5cpE+YdwJV x/EkYZl81sFXR3Cb7M0b+oetf31EjV3M6svAh9+aF3b/jHnZ/EN0LEyy4d6tKqKH S67GODO3HNp6rifBdfc2GQZJW2RW6b8xDTSMsG2HnXsn9AhpnQaY/72k9QF6y7/b xQM0G0yAm1z2EyfqlLYv5NHUiBfcnQiTF2o90VWLCf7StB0clr0bmqlPzpW5GvQ8 nxibmX4f0A0cdBwE3RJ4LNLY+TLHr85EIUdT4/AjFh1dRssMDhF8LrOlH0QRArtD Ba/bnkCYB3wbO0H04f2m+l/idIngzgN9gmndR49YG9rNwXIUZ3U= =0fIl -----END PGP SIGNATURE----- --oIlomvtVtXAVxSKT--