Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZQW4-00066H-Bd for pgsql-bugs@arkaria.postgresql.org; Wed, 19 Dec 2018 01:19:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gZQW2-0007Gr-Qj for pgsql-bugs@arkaria.postgresql.org; Wed, 19 Dec 2018 01:19:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZQW2-0007Gj-Gg for pgsql-bugs@lists.postgresql.org; Wed, 19 Dec 2018 01:19:14 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gZQVz-0003mC-Ph for pgsql-bugs@lists.postgresql.org; Wed, 19 Dec 2018 01:19:13 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E05D922006; Tue, 18 Dec 2018 20:19:10 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 18 Dec 2018 20:19:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=N+LGKCmWbVMF4N0p1BThyuid7YJ i7SNZFcq/orxY1/E=; b=Cy0ZKqZnY8mzcVpuH2YSTjJHlGcat1fQRsMeSP5WFeP twNMFafDMa5j0bI2k1SbKn8hLkKianftfOqHPHxQXy7OBGtHeXv0f6KOOUFTwNAu lBJbB9VMOyP4MoyDvAGFj7jmeF+BrYwZvpS5u9WLxDaJH5emo+UE0T+EWqRPQGMu 7GkpDN/EEScPY5teZkgDNcE/iRVHadY1oiWcT55wptGcRXKehPZ6dkaEBEyy65E8 9+5HT5BYn4A+grZcZV9CGwAonYzPRIAMKeSITcRPDCG4pS+Jc7gjH27zBrBTUF3H WAyVbVzZZL0kLEHaflgJHKQ1cwNebpEU4S53c8F93tg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=N+LGKC mWbVMF4N0p1BThyuid7YJi7SNZFcq/orxY1/E=; b=LYQm6QwGXVKMjPipyKJgCa TDQsxkSQMNbeKAAGygeUHAJrhH/KpWX3YCCRcP1T7ehgyEpp8F+tbc8tye8Epr0G k2n56R9gICQblWovRNE9UciRw+GWxED0gbUnw1i6gYUPHYMWIl9U2GPSom2+OeH3 Kn6e0inCYgi+uZSpJWiD6NoCPMn1UoCZsZTbtkEfPJ1zosQQefvVCjmVFuFpljU9 sx7I62xxtxvxA2xX68jy5CtIVYoeKAV8SAemVCz4fLWowJGIKehRoy3Oi5MKagrc 958HQz7PyGzTodOdB8MAjUqEV8ofZseud8wElOqjCj9bnMCLaesBQuj4JrrohOfA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeiledgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdefhe dmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefoihgt hhgrvghlucfrrghquhhivghruceomhhitghhrggvlhesphgrqhhuihgvrhdrgiihiieqne cuffhomhgrihhnpehpohhsthhgrhgvshhqlhdrohhrghenucfkphepiedurddvudehrddu feejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpehmihgthhgrvghlsehprghquh hivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id 0A45FE44D4; Tue, 18 Dec 2018 20:19:07 -0500 (EST) Date: Wed, 19 Dec 2018 10:19:04 +0900 From: Michael Paquier To: Amit Langote Cc: Etsuro Fujita , Luis Carril , "pgsql-bugs@lists.postgresql.org" , PG Bug reporting form Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction Message-ID: <20181219011904.GD2494@paquier.xyz> References: <15552-c64aa14c5c22f63c@postgresql.org> <8e82d10d-cc16-eed4-7634-3654f59d8053@lab.ntt.co.jp> <30718b48-8020-329a-c6f0-74e1222e5283@lab.ntt.co.jp> <5C18ECBB.2000507@lab.ntt.co.jp> <1c23a9b1-c9c0-a11a-63fc-d821602455ba@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zS7rBR6csb6tI2e1" Content-Disposition: inline In-Reply-To: <1c23a9b1-c9c0-a11a-63fc-d821602455ba@lab.ntt.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --zS7rBR6csb6tI2e1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 19, 2018 at 09:44:42AM +0900, Amit Langote wrote: > About adding guards in heap_sync itself to make sure that it becomes a > no-op for non-heap relations, I think that would make sense too. > Although, I wonder why it doesn't return without doing anything already, > given that it has this: >=20 > heap_sync(Relation rel) > { > /* non-WAL-logged tables never need fsync */ > if (!RelationNeedsWAL(rel)) > return; I think that you should be careful here as we want heap_sync to remain a rather low-level routine. For example: https://www.postgresql.org/message-id/20180919214858.65bwponiuqb3rnn2@alap3= =2Eanarazel.de -- Michael --zS7rBR6csb6tI2e1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwZnIgACgkQnvQgOdby QH0qghAAkwrywZxAifF7h1QLJe5XbW/lH/+JjFgentG46xYExQ7gRREi7ErGTa/K eB8Urmcb43fa1aSSzC0OvZ0AFbPn3wSjlANsGU79KdTmNcu52rbRlp5pC6xSbbyh if9DTZwjVJDYqkpxkS9uL9cypjm9FhLIzr0OM5w7uk221REC+xLZAu91GzWi/DKY D2f2heLwXvQo3+1fMauyGS5yVwlNKqN1HYTpTFk+BGlaGvjIMkW6CCYM3bH76V2Y UHvGazm4FD3xqFYN19yJdvq08dvEGZoP0Bv49nSfPQSi1J+Twv48Xk+UXQ8R/euS 7ajemNACGHQm51OOpmkAIT+oYh30vu2UHNLfzfTgkfbGswNBXCZXSym4NUJ14aqr 60WD0lRSUtfK41D0HTZDVWGnx5GeM3Hl2eZfYyHuHGsAEJmXIzdmirnJ9hIqK49w jWmHebj6tv8ewsC7mvx4Hu48rbP45SbRULPlMQsZQKHe8sJYuLsvRHUpubWasoma NEf4y/1Iijx86c5uasFEno8n9A/kConkOT0SCkZiv39mpHDIsJQyKXYz93dxVr6N i+9t8176z/Vl4FHuJRW1URCkomuilFWfGaZ2xB8UzNAP82ygrv+eL0PV/f4JJPpb vgITxPLaZri5BKWz7AIP8rCvnbgleKjV3/EppRPWm8xRVPb4KKE= =QeLl -----END PGP SIGNATURE----- --zS7rBR6csb6tI2e1--