Date: Fri, 21 Dec 2018 13:07:24 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
	Luis Carril <luis.carril@swarm64.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>,
	PG Bug reporting form <noreply@postgresql.org>,
	Michael Paquier <michael.paquier@gmail.com>
Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a
 transaction
Message-ID: <20181221040724.GF1886@paquier.xyz>
References: <5C18ECBB.2000507@lab.ntt.co.jp>
 <LEJPR01MB001074FD67CB65B539122E4DE7BD0@LEJPR01MB0010.DEUPRD01.PROD.OUTLOOK.DE>
 <3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp>
 <20181219023814.GA6577@paquier.xyz>
 <6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp>
 <5C19F7FF.9060904@lab.ntt.co.jp>
 <20181219083422.GA680@paquier.xyz>
 <5C1A0B6C.1040502@lab.ntt.co.jp>
 <20181220003140.GE27104@paquier.xyz>
 <5C1C62C5.8040409@lab.ntt.co.jp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="TmwHKJoIRFM7Mu/A"
Content-Disposition: inline
In-Reply-To: <5C1C62C5.8040409@lab.ntt.co.jp>
Precedence: bulk


--TmwHKJoIRFM7Mu/A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 21, 2018 at 12:49:25PM +0900, Etsuro Fujita wrote:
> (2018/12/20 9:31), Michael Paquier wrote:
>> Attached is the patch with two new test cases blowing with wal_level =3D
>> minimal.  On HEAD, I suggest that we use RELKIND_CAN_HAVE_STORAGE to not
>> fall again in this trap in the future.  For back-branches, let's just
>> add the appropriate relkind checks as suggested upthread.
>=20
> To make maintenance easy, I think it might be better to add the appropria=
te
> relkind checks on HEAD as well.  Other than that, the patch looks good to
> me.

Well, using RELKIND_CAN_HAVE_STORAGE is exactly to ease future
maintenance so as we don't fall again into the same trap if a new
relkind which has no physical storage gets introduced if it supports
COPY FROM.  So I would keep really it on HEAD.

> Thanks for the updated patch!

And thanks for taking the time to review the patch.
--
Michael

--TmwHKJoIRFM7Mu/A
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwcZvwACgkQnvQgOdby
QH3xOA/+MOspx4uFNb6Q+600vvwum9RX8ODgiRlWxgGc8uJ3Xc0Hm/iQ2hkckG0Z
Cvv5FYGy15SNHLlCWN1k1XHrd+dICGognA3BXrOwU+HV+kfWXeIe2+FxCvRdS+S7
xgayrDTYlkpXDkBHAz2BARdRNHKnKvs1vPn1b4VZSnlTNjUyuYfiueA1/9HZb4AD
2+Ng4h5qZ3TOcCOIObXi5kvdGIvlqBHwvdK4PU6qnjxUJ1+tWkVxDUXUqWjvzksk
Z5QJfIT+1G6ch5xGqlt4crCNuUNzPBeJTwYJeSltxaEFV1HAryBEjgMayiEhf4wG
WhglZBkw4DLa+iKJGYN31i+HW+eRR8cv1kjI9HYsd3fkULtcu7IfFEaYFkoKHbHD
YX9pZyZodM1y57iFu99WBY2/26GFAC8sK8BxuO859pMO9XmFMELCQfcbl2W9e8e6
UEoK3QvyChx3q2OI68PNDtA9saD7f+rpwzTMNTUczh7/G1Z713VpVjdOt/eatckd
oT6ccWc4tizucujfCRk7yqrCebqew6UQaRHfVLx4Usd76UEeFcsDRGzFp/vviZSF
b+cPxIjjtk0CMsLPHa9Ka1Hd9FTLVpboSt7HWtlAfSUiQ0B+eAC8EFjzQFVarUCJ
itGrApSkOdXc4YB8kAHAwK/z9zOpJKmsNPpgU7XexiOo3vlQbTU=
=7KFe
-----END PGP SIGNATURE-----

--TmwHKJoIRFM7Mu/A--