Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gaFas-0007Vu-N9 for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Dec 2018 07:51:38 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1gaFar-0002Kp-AM for pgsql-bugs@arkaria.postgresql.org; Fri, 21 Dec 2018 07:51:37 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gaFar-0002Ki-3z for pgsql-bugs@lists.postgresql.org; Fri, 21 Dec 2018 07:51:37 +0000 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gaFan-00013x-Pw for pgsql-bugs@lists.postgresql.org; Fri, 21 Dec 2018 07:51:36 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 4FAC614ED; Fri, 21 Dec 2018 02:51:31 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 21 Dec 2018 02:51:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=YMEsmbmpuBo4Cpo5D6VPW0RULXl lPa+IG3U3Wt13hwI=; b=B7Kp/BvsPuh5KFIvza4kqTMAmJrgtLX34BrJ2DqWhoT d8l4dUM7fYkjjNN2x2wiT0SKoW8niR+nMZVybrXDBOun2ctJZvHxTcdUZ6etDxTq ElXGZI1VS3MjOIC7NhNUtXx+oSnyZo2oQRbpLcLK+cVGBJ3gRG+a1V/Q55jQ+ex4 3NSYo6+mT82n7hwPohZ2dLIRwIU0uJSonFoxNnCe21u83Trops2cN08FRnB/kaJ3 b6YXJ2ZA/o6YYeN+KCtrbhwrB0u87auWXa76421vsfXyZW775s4fJ3d4muPtiMTJ P82aeaWHL8cLfi8jJNkYAajUPFA6YwG6dk83wiwYIfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=YMEsmb mpuBo4Cpo5D6VPW0RULXllPa+IG3U3Wt13hwI=; b=E7nycH76vjnTZwUPpHsz+l 6XNyp6dfYY4oKA74UoWG0qRyoe85Mi3kFdInX+n2SKEr73wz4dWmFqmO/ku6C6ap yvUUvDS8RJzjy0PDJbownAf0kp/lT6cAx+B94y76X2kfIMYGClL3yKVJgfJ2gEQJ Wj0Fps1KG3LgKHuNHwCQlz4O6s68DScn4GNM8mNBVBNEW1xmSbD+g011JhK6RDOO GcRA8rPCcSFIVbSfPp9tZo6IoWmDQAre87+O7Op7YjAQicozs4bYXFk5xDEbDdHe G06Uv315xVuAuyYFRtj7U5Neku/N22z1F/j6mvWpucNfg4cMUNTPJQ3Xr9TlZSAQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejgedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlje dtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhi tghhrggvlhcurfgrqhhuihgvrhcuoehmihgthhgrvghlsehprghquhhivghrrdighiiiqe enucfkphepiedurddvudehrddufeejrdduiedvnecurfgrrhgrmhepmhgrihhlfhhrohhm pehmihgthhgrvghlsehprghquhhivghrrdighiiinecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from paquier.xyz (c137162.net61215.cablenet.ne.jp [61.215.137.162]) by mail.messagingengine.com (Postfix) with ESMTPA id E8B0CE4385; Fri, 21 Dec 2018 02:51:26 -0500 (EST) Date: Fri, 21 Dec 2018 16:51:23 +0900 From: Michael Paquier To: Etsuro Fujita Cc: Amit Langote , Luis Carril , "pgsql-bugs@lists.postgresql.org" , PG Bug reporting form , Michael Paquier Subject: Re: BUG #15552: Unexpected error in COPY to a foreign table in a transaction Message-ID: <20181221075123.GA6876@paquier.xyz> References: <3539e73a-313a-5406-27c7-850affb47921@lab.ntt.co.jp> <20181219023814.GA6577@paquier.xyz> <6daa6d4a-d4a9-bd2c-0b84-c4e31d2b9844@lab.ntt.co.jp> <5C19F7FF.9060904@lab.ntt.co.jp> <20181219083422.GA680@paquier.xyz> <5C1A0B6C.1040502@lab.ntt.co.jp> <20181220003140.GE27104@paquier.xyz> <5C1C62C5.8040409@lab.ntt.co.jp> <20181221040724.GF1886@paquier.xyz> <5C1C75B2.9000008@lab.ntt.co.jp> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="liOOAslEiF7prFVr" Content-Disposition: inline In-Reply-To: <5C1C75B2.9000008@lab.ntt.co.jp> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --liOOAslEiF7prFVr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Dec 21, 2018 at 02:10:10PM +0900, Etsuro Fujita wrote: > My point here is that if doing so, we would have 3 versions in PG10, > PG11, and HEAD, which would make back-patching complicated. So my > taste would be to fix this on HEAD the same way as PG11, but I'm not > against using RELKIND_CAN_HAVE_STORAGE on HEAD. The conflicts would be a bit annoying yes, still those are minimal so I would still use the macro on HEAD. Let's see if others have an opinion. We will have a divergence between v10 and v11 anyway as v11 has added support for COPY with foreign tables, and v10 has added support for COPY with views. -- Michael --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwcm3sACgkQnvQgOdby QH0fKhAAg7z2FC6YnOs7jGhykfGlNKtgZ5f0DW/vhrQ3hiCalWL8SmNZfpgpmYFa 4sB+hM8kkH8tyWiOzUHetyIgB30QQPco1w7ZKRBr3le/X00uIZcuDz+wKV06rbr6 bB20DiqE0j+rnyuyFEvmSOMXKgikL5AErA3RTZ0lIzKu3s+Os6DPKZtDTt+oGeQz l4ILrqzQIc28kb8aEMnTQUI2N5RIE7kQbENyFZvwlyXRth9GRDsH5W4npQPgBt5O PrNUKlfT6wLbLYwZ/9o1uQ2JEXFoOC22h5p7XC3JnX5AL4OxYeeqGeCByCzbvPTU XTnr8JZm8jyo/TW5HqsUzPMcyOafxMk4RgI0CSVCPh8/8DJY2GynalHPY8ihqkG9 Pgpx0ON+oXqwTzwuKjtbZI3BC5Erb6dqX2aKXxmiM2z5BYmy78jOMJSDp2CUMH6a aGqhGkzb5+1KyYhjfkimeoq4fmz9FwxGhuolWZGLX86SMCltS2p/biq8w4/RPJSZ fqwM3BGR/8ld+4s0kid+2wEOUy4MmsesdD8dSvvasRecAE/93WT2H8Buzv3FbDMi 2RcAaawah98xUG4diGBgwYIQXL8bcK1M+4SwNFM6Huzrq6TpIaHsx5AlQW5ai+zP jk8NlL0aeU4B/W6kIAExV0JMlstSOz8HxenuNe2RUvo0XyTzAns= =FyBu -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--