Date: Thu, 3 Jan 2019 10:15:22 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Hugh Ranalli <hugh@whtc.ca>,
	Peter Eisentraut <peter.eisentraut@2ndquadrant.com>,
	thomas.munro@enterprisedb.com,
	Daniel Verite <daniel@manitou-mail.org>,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15548: Unaccent does not remove combining diacritical
 characters
Message-ID: <20190103011522.GA2107@paquier.xyz>
References: 
 <CAEepm=3gSmNWkteBxCEL-W+j1dmbcNzDin_iv+f_Om6o+1fAiA@mail.gmail.com>
 <CAAhbUMOX4QLj6c0O3GnjZYtR2dpAowss832Bq1n7oJyByeR7kQ@mail.gmail.com>
 <31564.1545078667@sss.pgh.pa.us>
 <CAAhbUMOe_VeJBxVqPe4Op2XKrT+xCcCvsUYRH4v6G71NDGG=fg@mail.gmail.com>
 <CAEepm=0qb_nx-f8cACS1=1NdmCj-3D9zXFU+RJHsFbZEztcqjg@mail.gmail.com>
 <CAAhbUMMzPERSe3KfKKQfR4COJCZSrss1G7KRyUraYJyvrVyOUg@mail.gmail.com>
 <CAAhbUMNyZ+PhNr_mQ=G161K0-hvbq13Tz2is9M3WK+yX9cQOCw@mail.gmail.co!m>
 <522acda7-c7fe-4b2e-f134-02c73a091be9@2ndquadrant.com>
 <CAAhbUMOG_S4DLQSDw3Jbqf8vipuvCAfxvH7T8+W2H0jFA-2K-g@mail.gmail.com>
 <23324.1546457552@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="T4sUOijqQbZv57TR"
Content-Disposition: inline
In-Reply-To: <23324.1546457552@sss.pgh.pa.us>
Precedence: bulk


--T4sUOijqQbZv57TR
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 02, 2019 at 02:32:32PM -0500, Tom Lane wrote:
> Seeing that supporting python 2 only adds a dozen lines of code,
> I vote for retaining it for now.  It'd be appropriate to drop that when
> python 3 is the overwhelmingly more-installed version, but AFAICT that
> isn't the case yet.

As a side note, if I recall correctly Python 2.7 will be EOL'd in
2020 by community, though I suspect that a couple of vendors will
still maintain compatibility for a couple of years in what they ship.
CentOS and RHEL enter in this category perhaps.  Like Peter, I would
vote for just maintaining support for Python 3 in this script, as any
modern development machines have it anyway, and not a lot of commits
involve it (I am counting 4 since 2015).
--
Michael

--T4sUOijqQbZv57TR
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAlwtYioACgkQnvQgOdby
QH2YXxAAiL9c9JsoVfaGT/WlXs9ysSZLCN4CJh91eNB2HOrzFBkqDTKzGi4EKwJR
AuYjQjOZkVKO0hOphCpMNtheRpoWB0t3eWiEi5OU5fnmIQHUIOGFasupHyfgmQdg
IOX3zidCkuwY1R3ioItxU8Vlk2UYdbRlwJOzaqVqkeotsOvjav82PD+gidxMHBrL
CRB6omViG3x2sZDMUDt5aXEnaZw29ykw1kozSrxyaWPAE7o6kHjrwvMmapRQuVA3
tDLxAgp0wmm9SAFhYjDviwWi2ETv0Ha1pkzzOwdopFGr7xORvaIYck4iV9K4zyfs
dEAWjemUjeoD5oF1XcUglxr03Y8FK8yQt3Mpz7JPdsOq5wLw467sAFCIn0fii3+7
gGQ+9Ogy6n86svJzGVlmFuK/rmZHSUM2Wbsr56meNKndIB0PX/Omey1pp4kMsoMy
EDz6aNayerlYJVuSdlyXpBM8emep6tNpbbb4qQPiDUaYLbh1ee1KsEmQFM63mwRU
f+1e+//fsqdVLszj0VHbEU5w9m5VwpyeOqfWzSgqZANGFGD8qluDt58XUS46YlF3
MQ8+Ua3ScHntO1GIq3C/HrBAb8aa5Tkn//nwafE5cgihnniZh6/FUuc9tJx4rFwQ
zGffbz30yx4aXmVoHTQogr2x1Evc3EgJ6k/r4VZDCCzAclzvHCw=
=K9L0
-----END PGP SIGNATURE-----

--T4sUOijqQbZv57TR--